Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's RxSwift 6.0 🚀 #172

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Conversation

tokijh
Copy link
Member

@tokijh tokijh commented Jan 4, 2021

[BE CAREFUL BEFORE MERGE]

This PR has dependent of #171. If you don't want merge #171, I'll revert #171 on this PR.

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #172 (10ce459) into master (fc392a1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files           8        8           
  Lines         143      143           
=======================================
  Hits          135      135           
  Misses          8        8           
Impacted Files Coverage Δ
Sources/ReactorKit/Reactor.swift 93.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc392a1...10ce459. Read the comment docs.

@bently93
Copy link

@devxoul please upgrade to rxswift 6

@devxoul devxoul changed the base branch from master to master2 February 2, 2021 12:36
@devxoul devxoul changed the base branch from master2 to master February 2, 2021 12:36
@devxoul devxoul merged commit 330bdf7 into ReactorKit:master Feb 2, 2021
@devxoul
Copy link
Member

devxoul commented Feb 2, 2021

Thanks for your contribution 🎉

@tokijh tokijh mentioned this pull request May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants