Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo is not rotated correctly in Camera1 #17

Closed
Diolor opened this issue May 9, 2017 · 6 comments
Closed

Photo is not rotated correctly in Camera1 #17

Diolor opened this issue May 9, 2017 · 6 comments
Assignees
Labels
Milestone

Comments

@Diolor
Copy link
Member

Diolor commented May 9, 2017

Device: Nexus 6P

Potentially due to sensor orientation degrees as camera 2 with other devices ( #12 ).

device-2017-05-09-231456

@Diolor Diolor added the bug label May 9, 2017
@Diolor Diolor added this to the 1.0.0 milestone May 9, 2017
@dmitry-zaitsev
Copy link
Member

@Diolor could you please tell me which parameters do you receive in OrientationUtils#computeImageOrientation and what is the output of the method?

@dmitry-zaitsev dmitry-zaitsev self-assigned this May 9, 2017
@Diolor
Copy link
Member Author

Diolor commented May 10, 2017

For Pixel XL:
Front camera:
screenRotationDegrees : 0, cameraRotationDegrees: 270, cameraIsMirrored: true
Output is at 90.
Back camera:
screenRotationDegrees : 0, cameraRotationDegrees: 90, cameraIsMirrored: false
Output is at 270.

For Nexus 6P:
Back/Front camera:
screenRotationDegrees : 0, cameraRotationDegrees: 90, cameraIsMirrored: false/true
Output is both at 270.

@dmitry-zaitsev
Copy link
Member

All good, I can reproduce it on my Nexus 5X.

@dmitry-zaitsev
Copy link
Member

@Diolor could you please check if fix/issue-17 branch works for you with Camera1 and Camera2?

@Diolor
Copy link
Member Author

Diolor commented May 11, 2017

both look ok on my 6P

@dmitry-zaitsev
Copy link
Member

Fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants