Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPL #109

Merged
merged 14 commits into from
May 23, 2020
Merged

REPL #109

merged 14 commits into from
May 23, 2020

Conversation

favonia
Copy link
Collaborator

@favonia favonia commented May 19, 2020 •
edited
Loading

Close #108.

  • Parsing commends
  • Basic REPL
  • Recovery from parsing errors
  • Modes

OPTIONAL:

  • Minimum completion, maybe
  • History

@favonia
Copy link
Collaborator Author

favonia commented May 20, 2020

@cangiuli @jonsterling

How about -m/--mode "i[nteractive]" or "s[cript]" to change modes? For example,

cooltt blah.cooltt
cooltt -m s blah.cooltt # same as above
cooltt -m s - # from stdin
cooltt -m i # no filenames allowed

We can have special v[im] mode I guess...

@favonia
A very low-Ch'i REPL mode.
39ebdca 
Also some refactoring.
@favonia favonia marked this pull request as ready for review May 22, 2020 23:05
jonsterling
jonsterling approved these changes May 22, 2020
View reviewed changes
Copy link
Collaborator

@jonsterling jonsterling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works!

@favonia
Copy link
Collaborator Author

favonia commented May 22, 2020 •
edited
Loading

@cangiuli now the scripting mode would print an additional line in the end (if there's an error). I hope that's not destroying the Vim mode.

EDIT: correct the comment

@favonia
Copy link
Collaborator Author

favonia commented May 22, 2020

@cangiuli Please feel free to change various new strings I added in main.ml for documentation and error messages.

cangiuli
cangiuli approved these changes May 23, 2020
View reviewed changes
Copy link
Collaborator

@cangiuli cangiuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not really test the REPL itself, but the rest looks great.

@favonia favonia merged commit a67719c into master May 23, 2020
@favonia favonia deleted the repl branch May 23, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonsterling jonsterling jonsterling approved these changes

@cangiuli cangiuli cangiuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REPL command deliminator
3 participants
@favonia @jonsterling @cangiuli