Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid loop at DocTable_Set #1498

Merged
merged 4 commits into from Oct 14, 2020
Merged

avoid loop at DocTable_Set #1498

merged 4 commits into from Oct 14, 2020

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Sep 5, 2020

Tiny optimization

@codecov
Copy link

codecov bot commented Sep 5, 2020 •
edited

Codecov Report

Merging #1498 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1498      +/-   ##
==========================================
+ Coverage   77.02%   77.03%   +0.01%     
==========================================
  Files         145      145              
  Lines       20767    20766       -1     
==========================================
+ Hits        15995    15998       +3     
+ Misses       4772     4768       -4
Impacted Files Coverage Δ
src/doc_table.c 61.42% <100.00%> (-0.12%) ⬇️
src/fork_gc.c 51.29% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e300e2c...b1c6baf. Read the comment docs.

@ashtul ashtul added the Post 2.0 label Sep 7, 2020
rafie
rafie previously approved these changes Oct 14, 2020
View reviewed changes
@ashtul ashtul requested a review from rafie October 14, 2020 14:41
@ashtul ashtul merged commit 06f52bf into master Oct 14, 2020
@ashtul ashtul deleted the avoid-loop-at-doctable-extension branch October 14, 2020 14:49
MeirShpilraien pushed a commit that referenced this pull request Nov 4, 2020
@ashtul @MeirShpilraien
avoid loop at DocTable_Set (#1498)
250f050 
* avoid loop at DocTable_Set
MeirShpilraien added a commit that referenced this pull request Nov 4, 2020
@MeirShpilraien @rafie
@gkorland @filipecosta90 @GnaneshKunal @ashtul @simonprickett
Cherrypicks to 2.0 (#1652)
8b85a5b 
* Clang sanitizers: updated Redis version to 6.0.8 (#1595)

* Add static analysis (#1603)

* [add] Moved c,cpp, and python tests to tests folder. Add googletest as submodule (#1399)

* Fix `average` typo (#1609)

* Fixed pytests/test_ext (#1612)

* fix slop when no diff between offsets + test (#1605)

unclear why there

* ft._list docs (#1611)

* ft._list docs

* per review

* avoid loop at DocTable_Set (#1498)

* avoid loop at DocTable_Set

* Prevent multiple sortby steps (#1614)

* MAXPREFIXEXPANSIONS config (#1625)

* MAXPREFIXEXPANSIONS config

* per review

* Fixed markdown issue in first video link (#1630)

The first video link was rendering incorrectly, fixed it.

* Minor typo fix. (#1631)

* Minor phrasing change. (#1636)

* Update CMakeLists.txt (#1644)

Fixes #1643.

* added thread local support to rwlock (#1328) (#1643)

* added thread local support to rwlock

* fix msan failure

* fix msan failure

* fix compilation error

* fix compilation error

* fix msan failure

* review fixes

Co-authored-by: Rafi Einstein <rafi@redislabs.com>
Co-authored-by: Guy Korland <gkorland@gmail.com>
Co-authored-by: filipe oliveira <filipecosta.90@gmail.com>
Co-authored-by: Gnanesh <gnaneshkunal@outlook.com>
Co-authored-by: Ariel Shtul <ashtul@gmail.com>
Co-authored-by: Simon Prickett <simon@crudworks.org>
ashtul added a commit that referenced this pull request Jan 18, 2021
@ashtul
avoid loop at DocTable_Set (#1498)
65f9356 
* avoid loop at DocTable_Set

(cherry picked from commit 06f52bf)
ashtul added a commit that referenced this pull request Jan 21, 2021
@ashtul @joeirimpan
@emmanuelkeller @MeirShpilraien @gkorland @rafie
[1.6] Cherry pick from master for 1.6.15 (#1761)
c57f828 
* Replace assert on limit of sortable fields (#1757)

(cherry picked from commit 5f7f105)

* Enforce 0 value for count reducer (#1745)

* Enforce 0 values for count

* fix rstest

* fix for centos

(cherry picked from commit 0ab57d6)

* feat: Add hindi snowball stemmer

(cherry picked from commit eac3594)

* Update snowball (#1708)

* Update snowball

* use rm allocator

(cherry picked from commit b3e86c2)

* [fix] parsing float scientific representation - Issue 1208 (#1225)

* fix ragel file

* test

* more precise

(cherry picked from commit 5eb145b)

* add STOPWORD to TAGLIST in query parser (#1668)

* add STOPWORD to TAGLIST

* use templete for parser.c

(cherry picked from commit fda9566)

* Revert "Update snowball (#1708)"

This reverts commit b2b49ea.

* Revert "feat: Add hindi snowball stemmer"

This reverts commit 4ee9026.

* return error for ft.alter w/o schema (#1754)

* return error for ft.alter w/o schema

* Add test

(cherry picked from commit 97f9d94)

* minTermPrefix & maxPrefixExpansions (#1774)

* minTermPrefix & maxPrefixExpansions

* fix rstest

(cherry picked from commit afc7e3c)

* Fix depth issue for score explain

(cherry picked from commit acdb772)

* Update Configuring.md

* Revert "Update Configuring.md"

This reverts commit 96e5a00.

* fix slop when no diff between offsets + test (#1605)

unclear why there

(cherry picked from commit 9de8286)

* use pointer instead of struct (#1591)

Co-authored-by: Rafi Einstein <rafi@redislabs.com>
(cherry picked from commit 56864b3)

* Sortby for non-sortable fields issue 1540 (#1574)

* sortby for non sortable fields issue 1540

(cherry picked from commit 1cd66d8)

* explicit error for EXPLAINSCORE w/o WITHSCORES (#1550)

* explicit error for EXPLAINSCORE w/o WITHSCORES

* per review

(cherry picked from commit 21b3d7f)

* avoid loop at DocTable_Set (#1498)

* avoid loop at DocTable_Set

(cherry picked from commit 06f52bf)

* Add test for LIMIT offset num (#1672)

* test

* updated test for coordinator

(cherry picked from commit 685929a)

* upgrade mkdocs (#1755)

(cherry picked from commit 84529a6)

* Fixed testCriteriaTesterDeactivated on macOS (#1660)

(cherry picked from commit 1e25d9e)

* fix tests

* Revert "Add test for LIMIT offset num (#1672)"

This reverts commit 8c6be73.

* Insert to suggest heap only if score larger than minimum - (#1689)

(cherry picked from commit ac0973d)

* Fix wrong arity for syndump (#1570)

(cherry picked from commit afbc834)

* skip or remove unrelated tests

* bump version to 1.6.15

* Fix stats report (#1517)

* Fix stats report

* remove unneeded ';'

* Update lastblkBytesCollected correctly

(cherry picked from commit 9c67a13)

* remove loom and rax - unused (#1521)

Co-authored-by: Rafi Einstein <rafi@redislabs.com>
(cherry picked from commit be7d847)

* Fixed build instructions (#1535)

(cherry picked from commit fef72dc)

* See RED-47209, fix crash when using WITHSORTKEYS without SORTBY (#1572)

(cherry picked from commit 11a6218)

* Prevent multiple sortby steps (#1614)

(cherry picked from commit 89095a6)

* added thread local support to rwlock (#1328) (#1643)

* added thread local support to rwlock

* fix msan failure

* fix msan failure

* fix compilation error

* fix compilation error

* fix msan failure

* review fixes

(cherry picked from commit 5977ef0)

Co-authored-by: Joe Paul <joeirimpan@gmail.com>
Co-authored-by: Emmanuel Keller <74923777+emmanuelkeller@users.noreply.github.com>
Co-authored-by: Emmanuel Keller <emmanuel.keller@redislabs.com>
Co-authored-by: Meir Shpilraien (Spielrein) <meir@redislabs.com>
Co-authored-by: Guy Korland <gkorland@gmail.com>
Co-authored-by: Rafi Einstein <rafi@redislabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafie rafie rafie approved these changes

@MeirShpilraien MeirShpilraien Awaiting requested review from MeirShpilraien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashtul @rafie