Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark #84

Merged
merged 7 commits into from
Jun 25, 2019
Merged

benchmark #84

merged 7 commits into from
Jun 25, 2019

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Jun 24, 2019

No description provided.

@ashtul ashtul requested a review from K-Jo June 24, 2019 12:08
@ashtul
Copy link
Contributor Author

ashtul commented Jun 25, 2019

@gkorland @itamarhaber @K-Jo
If someone can run this today to confirm it is OK and merge, it will be great.
I link to it in the blog post.

@K-Jo K-Jo removed request for K-Jo and itamarhaber June 25, 2019 07:52
@K-Jo
Copy link
Collaborator

K-Jo commented Jun 25, 2019

@swilly22 can you please review this?

swilly22
swilly22 suggested changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@swilly22 swilly22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, nothing fancy.

tests/benchmark.py Outdated Show resolved Hide resolved
tests/benchmark.py Show resolved Hide resolved
tests/benchmark.py Outdated Show resolved Hide resolved
tests/benchmark.py Outdated Show resolved Hide resolved
tests/benchmark.py Show resolved Hide resolved
@ashtul
Copy link
Contributor Author

ashtul commented Jun 25, 2019

@swilly22 @K-Jo
Good comments. Fixed!

@gkorland gkorland merged commit 80253de into master Jun 25, 2019
@ashtul ashtul deleted the benchmark branch June 25, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swilly22 swilly22 swilly22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashtul @K-Jo @swilly22 @gkorland