Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport !1163 to 2.4 #1165

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Backport !1163 to 2.4 #1165

merged 2 commits into from
Dec 21, 2023

Conversation

iddm
Copy link
Collaborator

@iddm iddm commented Dec 21, 2023

Backport #1163 to 2.4

@iddm iddm requested a review from oshadmi December 21, 2023 11:52
@iddm iddm self-assigned this Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e067ed0) 80.43% compared to head (b832dd8) 80.44%.

Files Patch % Lines
src/serde_value_manager.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.4    #1165      +/-   ##
==========================================
+ Coverage   80.43%   80.44%   +0.01%     
==========================================
  Files          15       15              
  Lines        3950     3953       +3     
==========================================
+ Hits         3177     3180       +3     
  Misses        773      773              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iddm iddm merged commit f9496d9 into 2.4 Dec 21, 2023
10 checks passed
@iddm iddm deleted the backport-1163-to-2.4 branch December 21, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants