Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RediSearch now supports arch64, so sbin/get-redisearch should as well. #523

Open
5HT2 opened this issue Nov 7, 2021 · 5 comments
Open
Assignees

Comments

@5HT2
Copy link

5HT2 commented Nov 7, 2021

See: https://github.com/RediSearch/RediSearch

Currently sbin/get-redisearch does not support arch64 on Linux. It would be great if this could be fixed.

@chayim chayim self-assigned this Nov 7, 2021
@chayim
Copy link
Contributor

chayim commented Nov 8, 2021

Hi! Currently we're not yet publishing arm based artifacts, though we will in the future. I've self-assigned for the future case.

@5HT2
Copy link
Author

5HT2 commented Nov 8, 2021

Thank you :)

There are currently unofficial modified images such as https://github.com/bbilly1/rejson which accomplish the same via manual compilation, as the official Docker image in this repo doesn't work due to the get-redisearch script

@bbilly1
Copy link

bbilly1 commented Dec 20, 2021

I'm checking in from time to time on the ARM64 progress, I know it's in the pipeline and I'm looking forward to an official release.

So this is just a FYI: I've successfully rebuild ReJSON for v2.0.6. No compilation errors, no runtime errors I can see, everything seems to be working just fine.

Dockerfile and build script used are here just in case but there were no modifications necessary: https://github.com/bbilly1/rejson

@5HT2
Copy link
Author

5HT2 commented Dec 21, 2021

Oh, it's good to know that no modifications are required now. It would be good if the maintainers popped in to check on this issue, as I'm unsure if it was an intentional change or if things just fixed themselves downstream.

@bbilly1
Copy link

bbilly1 commented Dec 21, 2021

Very much intentional, #550 #551 and more. Before these commits, there were some runtime dependency problems that required some unfortunate workarounds, but that's all fixed now. There were also some upstream fixes needed, but that's also merged: RedisLabsModules/readies#69.

I very much appreciate the progress happening!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants