Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid url when href is empty #2105

Merged
merged 1 commit into from
Jul 28, 2022
Merged

fix: invalid url when href is empty #2105

merged 1 commit into from
Jul 28, 2022

Conversation

AlexVarchuk
Copy link
Collaborator

@AlexVarchuk AlexVarchuk commented Jul 28, 2022 •
edited
Loading

What/Why/How?

we have an error with an invalid URL and fail tests.
Screenshot 2022-07-28 at 15 41 59
https://github.com/Redocly/redoc/runs/7559970321?check_suite_focus=true

step to reproduce:

  • update redoc version in redoc-cli to 2.0.0-rc.73

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

@AlexVarchuk AlexVarchuk requested a review from a team as a code owner July 28, 2022 13:11
@AlexVarchuk AlexVarchuk requested review from Oprysk and removed request for a team July 28, 2022 13:11
@AlexVarchuk AlexVarchuk self-assigned this Jul 28, 2022
@AlexVarchuk AlexVarchuk merged commit e5f0235 into master Jul 28, 2022
@AlexVarchuk AlexVarchuk deleted the fix/invalid-url branch July 28, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oprysk Oprysk Oprysk approved these changes

Assignees

@AlexVarchuk AlexVarchuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexVarchuk @Oprysk