Skip to content
This repository has been archived by the owner on Aug 25, 2019. It is now read-only.

Improvements: Fix php-fpm path, update base image on build, include APC #2

Merged
merged 3 commits into from
Nov 3, 2014
Merged

Improvements: Fix php-fpm path, update base image on build, include APC #2

merged 3 commits into from
Nov 3, 2014

Conversation

mattsta
Copy link
Contributor

@mattsta mattsta commented Nov 2, 2014

Three fixes! The APC install took way too long to figure out, but it's finally working (the problem was APC can only be enabled through the php-fpm.conf, not php.ini. If it's enabled in php.ini, nothing works!).

    Improve nginx.conf

    Workers can be higher and Phabricator complains if we have invalid
    paths in the config.

=======

    Update base image on build

    This is so we don't need to fetch new packages every time
    we `run` this Docker container.

    We just need to update base packages in this container at build
    time so we don't re-update every run.

=======

    Add APC support

    opensuse is stuck on PHP 5.4, so we can't use the PHP 5.5 built
    in opcode cache.  Until we use PHP 5.5 (or base all of this on
    a different system), we can use APC directly here.

    At this point, the entire image generates a _clean_ phabricator
    install with no "unresolved setup issues" except for the base
    case of "enable people to create accounts."

Workers can be higher and Phabricator complains if we have invalid
paths in the config.
This is so we don't need to fetch new packages every time
we `run` this Docker container.

We just need to update base packages in this container at build
time so we don't re-update every run.
opensuse is stuck on PHP 5.4, so we can't use the PHP 5.5 built
in opcode cache.  Until we use PHP 5.5 (or base all of this on
a different system), we can use APC directly here.

As of this commit, this entire image generates a _clean_ phabricator
install with no "unresolved setup issues" except for the base
case of "enable people to create accounts."
@hach-que
Copy link
Contributor

hach-que commented Nov 3, 2014

Looks good to me.

The image will still perform security updates on boot though, regardless of the "RUN zypper --non-interactive patch" commands.

hach-que added a commit that referenced this pull request Nov 3, 2014
Improvements: Fix php-fpm path, update base image on build, include APC
@hach-que hach-que merged commit b7d8ee7 into RedpointArchive:master Nov 3, 2014
@mattsta
Copy link
Contributor Author

mattsta commented Nov 3, 2014

Thanks!

The image will still perform security updates on boot though

Yeah, that's always good as a default. Letting the image pull its own updates on build is just a bonus so we can cheat without having to re-build a custom parent image too. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants