Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape single quotes in printf to neurodocker_specs.json #443

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Apr 12, 2022

Single quotes in the Dockerfile need to be escaped before using printf to save them to file

@tclose
Copy link
Contributor Author

tclose commented Apr 28, 2022

Hi @kaczmarj, any chance you could take a look at this as it is blocking the release of my package on PyPI? Thanks!

@kaczmarj
Copy link
Collaborator

@tclose - thanks for the ping. quotes have always given me trouble... let's wait until the CI passes and then i'll merge

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #443 (33b5bb0) into master (664965c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   88.57%   88.58%   +0.01%     
==========================================
  Files          11       11              
  Lines        1015     1016       +1     
==========================================
+ Hits          899      900       +1     
  Misses        116      116              
Impacted Files Coverage Δ
neurodocker/reproenv/renderers.py 93.36% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 664965c...33b5bb0. Read the comment docs.

@kaczmarj kaczmarj merged commit 65067b6 into ReproNim:master Apr 29, 2022
@tclose tclose deleted the printf-escape-single-quote branch June 2, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants