added _Renderer.labels method that enables adding labels with special chars in the label name #453
Conversation
… chars in the label name
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
==========================================
+ Coverage 88.58% 88.61% +0.03%
==========================================
Files 11 11
Lines 1016 1019 +3
==========================================
+ Hits 900 903 +3
Misses 116 116
Continue to review full report at Codecov.
|
apparent bug in SingularityRender.label where multiple labels weren't separated by newlines
|
Also fixes an apparent bug in the Singularity renderer where multiple labels weren't being separated by newlines |
|
@kaczmarj do you have an ETA on the next Neurodocker release? I'm gearing up to make an Arcana release but need some bug fixes that are in the Neurodocker master |
|
@tclose - thanks for the PR and bugfix. looks good to me. i hadn't considered label names that had special characters. would a release next week be good for you? |
|
Hi @kaczmarj, no worries, thanks for the nice package! A release next week would be great. |
|
@tclose - i have not forgotten about this. grant writing is taking up all of my time and haven't found a good moment to do this. feel free to ping me here if i don't respond soon enough. |
|
Hi @kaczmarj, any updates on the ETA of a new release? This is my only blocker at the moment |
|
@tclose - thanks for being patient with me... this grant is due wednesday night, so thursday will be new release.
|
|
hi @tclose - release 0.9.1 is available! https://pypi.org/project/neurodocker/0.9.1/ and release notes are at https://github.com/ReproNim/neurodocker/releases i released 0.9.0 with the changes from this pr (and a few others), but then i fixed another issue... so i released 0.9.1. |
|
Awesome, thanks a lot! |
As the title says, this PR addresses the issue raised in #444