Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli.rst #514

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Update cli.rst #514

merged 2 commits into from
Mar 3, 2023

Conversation

sooyounga
Copy link
Collaborator

updated to include --yes flag in the docs based on #508

  • did not change the help messages in the python files, but it can be if needed?

added other missing flags, including --json flag, as well as missing options and versions, etc. from checking diff with what the neurodocker generate docker --help command generates currently

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (e766064) 88.77% compared to head (d291420) 88.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
- Coverage   88.77%   88.75%   -0.02%     
==========================================
  Files          11       11              
  Lines        1033     1032       -1     
==========================================
- Hits          917      916       -1     
  Misses        116      116              
Impacted Files Coverage Δ
neurodocker/cli/generate.py 91.62% <0.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sooyounga sooyounga linked an issue Feb 23, 2023 that may be closed by this pull request
@djarecka
Copy link
Member

@sooyounga - looks good, but could you also check if the neurodocker generate singularity --help has changed?

updated to include --yes flag in the docs based on #508
- did not change the help messages in the python files, but it can be if needed?

added other missing flags, including --json flag, as well as missing options and versions, etc. from checking diff with what the `neurodocker generate docker --help` and `neurodocker generate singularity --help` commands generate currently
@djarecka djarecka merged commit 2bea183 into master Mar 3, 2023
@stebo85 stebo85 deleted the sooyoung-update-cli-docs branch August 22, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--yes option doesn't do anything?
2 participants