-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modifying value for entry point to allow -arg or --arg #515
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #515 +/- ##
==========================================
+ Coverage 88.77% 88.79% +0.02%
==========================================
Files 11 11
Lines 1033 1035 +2
==========================================
+ Hits 917 919 +2
Misses 116 116
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
let me test this and get back to you. thanks for tackling the issue |
thanks dorota, this works for me. i ran the following neurodocker generate docker --base-image debian --pkg-manager apt --entrypoint "bash -c" and I got the following Dockerfile: # Generated by Neurodocker and Reproenv.
FROM debian
ENTRYPOINT ["bash", "-c"]
# Save specification to JSON.
RUN printf '{ \
"pkg_manager": "apt", \
"existing_users": [ \
"root" \
], \
"instructions": [ \
{ \
"name": "from_", \
"kwds": { \
"base_image": "debian" \
} \
}, \
{ \
"name": "entrypoint", \
"kwds": { \
"args": [ \
"bash", \
"-c" \
] \
} \
} \
] \
}' > /.reproenv.json
# End saving to specification to JSON. |
feel free to merge once the tests pass |
this PR would allow to have
-arg
and--arg
when using "", e.g. "command -arg"fixes #507