Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifying value for entry point to allow -arg or --arg #515

Merged
merged 6 commits into from
Apr 3, 2023

Conversation

djarecka
Copy link
Member

this PR would allow to have -arg and --arg when using "", e.g. "command -arg"

fixes #507

@djarecka djarecka mentioned this pull request Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (19b6a94) 88.77% compared to head (85cf1b7) 88.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   88.77%   88.79%   +0.02%     
==========================================
  Files          11       11              
  Lines        1033     1035       +2     
==========================================
+ Hits          917      919       +2     
  Misses        116      116              
Impacted Files Coverage Δ
neurodocker/cli/generate.py 91.73% <100.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djarecka djarecka requested review from satra and kaczmarj March 14, 2023 18:45
@kaczmarj
Copy link
Collaborator

let me test this and get back to you. thanks for tackling the issue

@kaczmarj
Copy link
Collaborator

thanks dorota, this works for me. i ran the following

neurodocker generate docker --base-image debian --pkg-manager apt --entrypoint "bash -c"

and I got the following Dockerfile:

# Generated by Neurodocker and Reproenv.

FROM debian
ENTRYPOINT ["bash", "-c"]

# Save specification to JSON.
RUN printf '{ \
  "pkg_manager": "apt", \
  "existing_users": [ \
    "root" \
  ], \
  "instructions": [ \
    { \
      "name": "from_", \
      "kwds": { \
        "base_image": "debian" \
      } \
    }, \
    { \
      "name": "entrypoint", \
      "kwds": { \
        "args": [ \
          "bash", \
          "-c" \
        ] \
      } \
    } \
  ] \
}' > /.reproenv.json
# End saving to specification to JSON.

@kaczmarj
Copy link
Collaborator

feel free to merge once the tests pass

@kaczmarj kaczmarj merged commit f2f42e1 into ReproNim:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing of entrypoints
2 participants