refactor(toolbox): addAggregator immutable args #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
benjlevesque,
KolevDarko,
leoslr and
olivier7delf
| await runUpdate('updateAggregator', [input, output, aggregator], args); | ||
| assert(aggregatorAddress); | ||
|
|
||
| await runUpdate('updateAggregator', [inputAddress, outputAddress, aggregatorAddress], args); |
There was a problem hiding this comment.
It's now easier to understand what we are passing by to the next function: addresses.
| let { input, output, aggregator } = args; | ||
| const { input, output, aggregator: aggregatorArg } = args; |
There was a problem hiding this comment.
This is the main change
benjlevesque
approved these changes
Oct 11, 2023
leoslr
approved these changes
Oct 12, 2023
KolevDarko
approved these changes
Oct 16, 2023
MantisClone
reviewed
Oct 17, 2023
Co-authored-by: MantisClone <david.huntmateo@request.network>
olivier7delf
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
This is a follow-up to @olivier7delf 's comment (here) on #1134
This makes the args immutable (replaced
letbyconst) and variable manipulations a bit clearer.