fix: missing eth-proxy on BSC #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
alexandre-abrioux,
bertux,
KolevDarko and
leoslr
bertux
approved these changes
Feb 28, 2022
alexandre-abrioux
approved these changes
Mar 1, 2022
olivier7delf
pushed a commit
that referenced
this pull request
Mar 2, 2022
olivier7delf
pushed a commit
that referenced
this pull request
Mar 2, 2022
olivier7delf
pushed a commit
that referenced
this pull request
Mar 2, 2022
olivier7delf
pushed a commit
that referenced
this pull request
Mar 2, 2022
olivier7delf
pushed a commit
that referenced
this pull request
Mar 2, 2022
olivier7delf
pushed a commit
that referenced
this pull request
Mar 2, 2022
olivier7delf
pushed a commit
that referenced
this pull request
Mar 2, 2022
Signed-off-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com>
olivier7delf
added a commit
that referenced
this pull request
Mar 2, 2022
* modification to allow payment with wrong fee address, test for erc20 fee-proxy-contract.test Signed-off-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com> * feat: ether to smart wallet payment (#780) Signed-off-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com> * fix: missing eth-proxy on BSC (#791) Signed-off-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com> * feat: Start of SuperFluid integration (#671) Signed-off-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com> * test ok on any-to-erc20-proxy-contract.test.ts Signed-off-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com> * clear comment Signed-off-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com> * clean comments Signed-off-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com> * Update any-to-erc20-proxy-contract.test.ts rename the test, to understand that: - payment & refund work even with the wrong feeAddress - feeBalance sum only if feeAddress is fine Signed-off-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com> * Update any-to-erc20-proxy-contract.test.ts clean comments Signed-off-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com> * Update fee-proxy-contract.test.ts rename the test, to underline that: - payment & refund work even with the wrong feeAddress - feeBalance sum only if feeAddress is fine Signed-off-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com> * Update packages/payment-detection/test/erc20/fee-proxy-contract.test.ts Co-authored-by: Alexandre ABRIOUX <alexandre-abrioux@users.noreply.github.com> Signed-off-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com> * Update packages/payment-detection/test/erc20/fee-proxy-contract.test.ts Co-authored-by: Alexandre ABRIOUX <alexandre-abrioux@users.noreply.github.com> Signed-off-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com> Co-authored-by: leoslr <50319677+leoslr@users.noreply.github.com> Co-authored-by: Benjamin Levesque <14175665+benjlevesque@users.noreply.github.com> Co-authored-by: Bertrand Juglas <b@juglas.name> Co-authored-by: Alexandre ABRIOUX <alexandre-abrioux@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.