Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing scheduled tests #798

Merged
merged 6 commits into from
Mar 11, 2022
Merged

fix: fixing scheduled tests #798

merged 6 commits into from
Mar 11, 2022

Conversation

KolevDarko
Copy link
Contributor

Fixing the failing nightly tests, located in integration-tests/test/scheduled

  • Adding feeAddress and feeAmount to Erc20FeeProxy requests because they are mandatory.
  • Increased the timeout to some of the tests because I was getting timeout errors, perhaps because it's local environment.
  • Had to change the network from private to rinkeby for the Eth input data tests. I was getting errors saying network private not supported for this payment detection because we're using chain explorer for the detection I believe.

@KolevDarko KolevDarko requested review from benjlevesque and kevindavee and removed request for bertux, alexandre-abrioux and leoslr March 10, 2022 08:55
Copy link
Contributor

@benjlevesque benjlevesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done 👏

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.842% when pulling 23e7355 on fix/fixing-scheduled-tests into c4c2276 on master.

@KolevDarko KolevDarko merged commit 332e3ab into master Mar 11, 2022
@KolevDarko KolevDarko deleted the fix/fixing-scheduled-tests branch March 11, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants