Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indicate that the current origin is allowed through different color flag icon #22

Open
jsamuel opened this issue Dec 22, 2011 · 2 comments

Comments

@jsamuel
Copy link
Member

jsamuel commented Dec 22, 2011

imported trac ticket
created: 2009-06-21 19:57:54
reporter: Chris Buijs

It would be nice to have an indication that the webpage one is at is in the "allowed" origins whitelist so people realize that every request from this page is being allowed. I suggest turning the flag green when this is the case.

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2009-12-13 21:47:56
author: justin

The idea make sense: indicate that it's an allowed origin so the user doesn't forget and lose security/privacy because they assume that there's just no cross-site requests. However, it's greatly complicated by the existence of "other origin" cross-site requests.

How would the icon indicate in this case that all requests from the current origin are allowed but there are still blocked requests? I guess it would still turn red in that case. That might run the risk of a user seeing red and thinking that cross-site requests are blocked, including all requests from the origin, even though they aren't. However, that's probably the same risk as with how things are right now and, really, "other origin" requests aren't very common outside of youtube.com and a small number of other domains.

I think this needs some more thought but, at the moment, I like the idea. One hesitation I have is to wonder if there may be other situations that we'll discover in the coming year that green might be better suited for. Also, I wonder if green is ok as it might indicate a feeling of trust when part of the goal is to lightly warn the user. On the other hand, as it would turn green right after they choose to trust the origin, I think it would be clear what it stands for. There also aren't many other colors to choose from.

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2010-05-02 18:12:33
author: eibwen

See also #98, which proposes further revision and additional colors for other states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant