SeaMonkey: context menu "open link in new tab" fails

[jsamuel]

imported trac ticket
created: 2009-07-25 13:38:58
reporter: justin

On !SeaMonkey 2.0b2pre, using "open link in new tab" fails when trying to open a cross-site link. What you get is a blank tab and the following message which looks like the browser reacting to !ShouldLoad returning false for the url it's trying to display in the new tab:

{{{
Error: uncaught exception: [Exception... "Component returned
failure code: 0x805e000a [nsIWebNavigation.loadURI]" nsresult:
"0x805e000a ()" location: "JS frame :: chrome://global/content/bindings/browser.xml
:: loadURIWithFlags :: line 186" data: no]
}}}

The fundamental problem is that our registerLinkClicked() function is not getting called. There is some chance this is the result of the crappy workaround for !TabMixPlus in our _wrapAddTab() function in overlay.js.

[jsamuel]

imported trac comment
created: 2009-09-18 09:51:17
author: justin

Fixed in r269. The specific problem wasn't the same, though. The issue was that the seamonkey addTab() function changed to look like this:

{{{
function addTab(aURI, aReferrerURI, aCharset, aFocusNewTab, aFlags) {
}}}

rather than this:

{{{
function addTab(aURI, aReferrerURI, aCharset, aPostData, aOwner, aAllowThirdPartyFixup)
}}}

so our previous code that modified addTab() was failing.