Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image tags without ending slash are never made responsive. #259

Closed
joemcgill opened this issue Nov 28, 2015 · 4 comments
Closed

Image tags without ending slash are never made responsive. #259

joemcgill opened this issue Nov 28, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@joemcgill
Copy link
Member

See https://core.trac.wordpress.org/ticket/34807.

Looks like we're going to go back to a custom regex for finding images embedded in content, rather than using get_media_embedded_in_content(). Let's wait for the ticket in core to resolve and then apply the same update here.

@joemcgill joemcgill modified the milestone: 3.1.1 Nov 28, 2015
@joemcgill joemcgill added the bug label Nov 28, 2015
@joemcgill
Copy link
Member Author

Fixed in core here: https://core.trac.wordpress.org/changeset/35753

Let's do the same here.

@joemcgill joemcgill self-assigned this Dec 1, 2015
@jaspermdegroot
Copy link
Member

What shall we do with tevkori_get_media_embedded_in_content()? It isn't marked as private function so I suppose we have to deprecate it first before removing it.

@joemcgill
Copy link
Member Author

I suppose you're right. I'll move it over to the deprecated functions file and we can remove it in 3.2.

@joemcgill
Copy link
Member Author

Fixed in #262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants