New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the jibx maven plugin #48

Closed
angrygreenfrogs opened this Issue Jul 11, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@angrygreenfrogs
Collaborator

angrygreenfrogs commented Jul 11, 2016

The full back-story is here: #44

The end result was that I put a work-around in place that uses the maven jibx plugin for the "generate-code" step, but then directly calls a local copy of jibx for the binding process and avoids the plugin due to a weird bug.

Considering the plugin is getting out of date and seems to be unmaintained, I'm leaning towards saying we just remove it and replace the generate-code step as well with a direct call to JiBX. This is mostly a reminder so I'll figure that out later and do it.

@angrygreenfrogs

This comment has been minimized.

Collaborator

angrygreenfrogs commented Jul 11, 2016

At present the JiBX jar files are directly included in the GMLC code-base. If we remove the plugin and go with directly using jibx, perhaps we can still find a way to have it be a downloaded dependency rather than including the jars as I have at the moment.

@angrygreenfrogs

This comment has been minimized.

Collaborator

angrygreenfrogs commented Aug 1, 2016

@FerUy I'm going to take this one over and just get it resolved shortly.

@angrygreenfrogs

This comment has been minimized.

Collaborator

angrygreenfrogs commented Aug 1, 2016

The decision is to remove the maven plugin as per comments above.

@angrygreenfrogs angrygreenfrogs changed the title from Either fix or remove the jibx maven plugin to Remove the jibx maven plugin Aug 1, 2016

@FerUy

This comment has been minimized.

Contributor

FerUy commented Aug 1, 2016

Agreed in the decision taken, was about to propose that too.
Thanks @angrygreenfrogs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment