Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding service id #81

Merged
merged 2 commits into from
Mar 29, 2017
Merged

adding service id #81

merged 2 commits into from
Mar 29, 2017

Conversation

loayking
Copy link
Collaborator

@loayking loayking commented Sep 3, 2016

Adding service id to GMLC request help to identify the issuer requester, and it can be use for privilege access, CDR's analysis , reports ....etc

@FerUy FerUy added this to the 2.0.0 milestone Sep 3, 2016
@FerUy FerUy self-assigned this Sep 3, 2016
@FerUy
Copy link
Contributor

FerUy commented Mar 22, 2017

Hi @loayking. I think I got you, however could you please give a brief description on this pull request?
Thanks in advance.

@loayking
Copy link
Collaborator Author

Hi @FerUy is it ok now

BR

@FerUy
Copy link
Contributor

FerUy commented Mar 24, 2017

Yes @loayking, thanks!
You'll receive news about this very soon. Just checking that all pieces "dance" together, not only with GMLC but Restcomm Geolocation API.

@FerUy FerUy merged commit cb187b4 into RestComm:master Mar 29, 2017
@FerUy FerUy removed the peer review label Mar 29, 2017
@FerUy
Copy link
Contributor

FerUy commented Mar 29, 2017

Thanks @loayking for your contribution, liked it and merged!

@loayking
Copy link
Collaborator Author

thank you @FerUy

@FerUy FerUy mentioned this pull request Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants