Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add requested service #79

Closed
loayking opened this issue Sep 1, 2016 · 5 comments
Closed

add requested service #79

loayking opened this issue Sep 1, 2016 · 5 comments
Assignees

Comments

@loayking
Copy link
Collaborator

loayking commented Sep 1, 2016

Hi @ALL, I think we need to add requested service parameter as follow
http://127.0.0.1:8080/restcomm/gmlc/rest?msisdn=87583439&requested=*888#
this will help later in CDR

@FerUy FerUy added this to the 2.0.0 milestone Sep 1, 2016
@loayking
Copy link
Collaborator Author

loayking commented Sep 3, 2016

Hello @FerUy , please check the changes @ https://github.com/RestComm/gmlc/compare/master...loayking:Me?expand=1

I select URL parameter name serviceid instead of requested,
and i supposed the tag in MLP request is for the same .
if it is ok i will make pull request

@FerUy
Copy link
Contributor

FerUy commented Sep 3, 2016

Thanks @loayking, please proceed with the PR. It will be merged for milestone 2.0.0, after we complete issue #23 which will hopefully happen next Monday.

@loayking
Copy link
Collaborator Author

loayking commented Sep 3, 2016

done @FerUy

@FerUy
Copy link
Contributor

FerUy commented Sep 3, 2016

Thanks!

@FerUy
Copy link
Contributor

FerUy commented Mar 30, 2017

Closed by #81

@FerUy FerUy closed this as completed Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants