Fix transport parameter in load balancer Route #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a TLS target has to be contacted, but load balancer is set to terminate TLS, the server will send the request via TCP, even though the Request-URI contains ;transport=tls. In this case, JainSipUtils.findTransport will report "tls" transport, but that is not what should be used in the Route header if a connector with a different transport is used. The Route's transport and port should match the listening point of the load balancer, which will be TCP in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a TLS target has to be contacted, but load balancer is set to terminate TLS, the server will send the request via TCP, even though the Request-URI contains ;transport=tls. In this case, JainSipUtils.findTransport will report "tls" transport, but that is not what should be used in the Route header if a connector with a different transport is used. The Route's transport and port should match the listening point of the load balancer, which will be TCP in this case.