Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Context::stop_all to Address #96

Closed
thomaseizinger opened this issue Jun 21, 2022 · 1 comment
Closed

Move Context::stop_all to Address #96

thomaseizinger opened this issue Jun 21, 2022 · 1 comment

Comments

@thomaseizinger
Copy link
Collaborator

thomaseizinger commented Jun 21, 2022

A Context is usually not available other than from within an actor's Handler and thus, this feature cannot be used from all places.

I'd claim that most likely, a piece of code shutting down all instances of a set of actors will be outside those actors and thus, would likely want to do this from the Address. An Address can still be acquired from a Context so this can still be used from within a Handler.

Additionally, to make progress on #91, we need to remove as many APIs from Context as possible and this one is using the sender which is already embedded in an Address so it is easy to port.

@thomaseizinger
Copy link
Collaborator Author

We agreed that this fits better onto Context! See linked PRs for discussion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant