Carousel Scrolling Sound & Back Sound Don't Work

[lilbud]

I wanted to add some sounds to my Switch theme, I currently have 3:

back.wav
scroll.wav
select.wav
I wanted these sounds to play at their respective times. "Scroll.wav" would play when selecting a system on the carousel as well as in the gamelist. The sound will only play when added to the textlist code. But crashes the theme when added under carousel.

Similarly, I wanted "back.wav" to play when going back to the system select from the gamelist, but that doesn't work. "Select.wav" works fine when choosing a game.

Could sound support be added for the carousel and as an exit sound?

[benjdero]

One of my next step is to add scroll sound to the GridView, I think I'm going to extend my goal to "refactoring" how the sounds for navigation are handled.

Here is how I see it :

I don't remember where I saw it first, but for me a good way for themes to manage sounds would by adding that code to the end of their theme :

<!-- Sound -->
<view name="basic, detailed, grid, system">
	<sound name="back">
		<path>./art/menu-back.wav</path>
	</sound>
	<sound name="launch">
		<path>./art/menu-validate.wav</path>
	</sound>
	<sound name="select">
		<path>./art/menu-select.wav</path>
	</sound>
</view>

And then it would apply the scroll sound (called "select" here) the launch and back sound, to every single list, whatever it is the grid from the gridview, the list from the basic and detailed view, the carousal, and maybe for the menu too.

The "scrollSound" attribute of the gamelist would be kept for backward compatibility with old themes in a first time, until a certain % of the themes switch to the new syntax then it will be dropped. If a theme define both a scrollSound for the gamelist and a general "select" sound, then the scrollSound will be ignored.

EDIT : actually this thing about back, launch and select sound is already half here, the launch sound is used, the back sound isn't because the part of the code who play this sound is never called, and the select sound is completly ignored.

[benjdero]

@lilbud I need your help, is that from one of your themes that I saw this code ? Or was it from EmulationStation source code ? I don't remember at all.

[lilbud]

I think at one point I mentioned adding the sounds to one of my themes, but I probably never did. That code you posted is how sounds should be added to a theme.