Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.16.1 to 2.17.0 #751

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 24, 2022

Bumps rubocop-rails from 2.16.1 to 2.17.0.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.17.0

New features

Bug fixes

  • #786: Fix a false negative for Rails/ActionControllerTestCase when extending ActionController::TestCase and having a method definition. (@​koic)
  • #792: Fix a false negative for Rails/RedundantPresenceValidationOnBelongsTo when belongs_to at least one block and one hash like belongs_to :company, -> { where(foo: true) }, inverse_of: :employee. (@​PedroAugustoRamalhoDuarte)
  • #781: Make Rails/DynamicFindBy aware of find_by_token_for. (@​koic)
  • #809: Fix an error for Rails/FreezeTime when using travel_to without argument. (@​koic)
  • #794: Fix an error for Rails/RedundantReceiverInWithOptions when calling a method with a receiver in with_options without block arguments. (@​koic)
  • #782: Fix an incorrect autocorrect for Rails/EagerEvaluationLogMessage when using Style/MethodCallWithArgsParentheses's autocorrection together. (@​koic)
  • #776: Fix an incorrect autocorrect for Rails/Presence when using arithmetic operation in else branch. (@​koic)
  • #813: Fix errors that occur when unrelated tag is investigated by Rails/ContentTag. (@​r7kamura)
  • #808: Fix false positive for Rails/ActionControllerFlashBeforeRender when render call precedes flash call. (@​americodls)
  • #778: Fix a false positive for Rails/DynamicFindBy when using page.find_by_id as a Capybara testing API. (@​koic)
  • #816: Fix an incorrect autocorrect for Rails/Presence when a right-hand side of the relational operator. (@​ydah)

Changes

Changelog

Sourced from rubocop-rails's changelog.

2.17.0 (2022-10-22)

New features

Bug fixes

  • #786: Fix a false negative for Rails/ActionControllerTestCase when extending ActionController::TestCase and having a method definition. ([@​koic][])
  • #792: Fix a false negative for Rails/RedundantPresenceValidationOnBelongsTo when belongs_to at least one block and one hash like belongs_to :company, -> { where(foo: true) }, inverse_of: :employee. ([@​PedroAugustoRamalhoDuarte][])
  • #781: Make Rails/DynamicFindBy aware of find_by_token_for. ([@​koic][])
  • #809: Fix an error for Rails/FreezeTime when using travel_to without argument. ([@​koic][])
  • #794: Fix an error for Rails/RedundantReceiverInWithOptions when calling a method with a receiver in with_options without block arguments. ([@​koic][])
  • #782: Fix an incorrect autocorrect for Rails/EagerEvaluationLogMessage when using Style/MethodCallWithArgsParentheses's autocorrection together. ([@​koic][])
  • #776: Fix an incorrect autocorrect for Rails/Presence when using arithmetic operation in else branch. ([@​koic][])
  • #813: Fix errors that occur when unrelated tag is investigated by Rails/ContentTag. ([@​r7kamura][])
  • #808: Fix false positive for Rails/ActionControllerFlashBeforeRender when render call precedes flash call. ([@​americodls][])
  • #778: Fix a false positive for Rails/DynamicFindBy when using page.find_by_id as a Capybara testing API. ([@​koic][])
  • #816: Fix an incorrect autocorrect for Rails/Presence when a right-hand side of the relational operator. ([@​ydah][])

Changes

  • #779: Add mail to AllowedMethods of Style/SymbolProc. ([@​koic][])
  • #796: Add several directories to Exclude to prevent slow investigation. ([@​koic][])
  • #822: Extends Rails/HttpStatus cop to check routes.rb. ([@​anthony-robin][])
  • #787: Make Rails/Pluck aware of all keys. ([@​koic][])
  • #800: Make Rails/TimeZone aware of timezone UTF offset. ([@​inkstak][])
Commits
  • 177c92f Cut 2.17.0
  • 1cb96f9 Update Changelog
  • e40d8b9 Merge pull request #823 from anthony-robin/http-status-routes
  • 1dcbda1 [Fix #822] Extends Rails/HttpStatus cop to check routes.rb
  • 6051ed8 Merge pull request #806 from koic/add_mail_to_allowed_methods_of_style_symbol...
  • 25d9dfb Merge pull request #816 from ydah/fix/presence
  • 4b6362e Fix an incorrect autocorrect for Rails/Presence when a right-hand side of t...
  • 7a434e4 Tweak an changelog for Rails/SetIgnoredColumns
  • d7db4d1 Merge pull request #817 from ydah/change/presence
  • 43fa456 Preserve multiline semantics on Rails/Presence
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nilsding.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Oct 24, 2022
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 88.07% // Head: 88.07% // No change to project coverage 👍

Coverage data is based on head (3147f8d) compared to base (d3faccf).
Patch has no changes to coverable lines.

❗ Current head 3147f8d differs from pull request most recent head f567a18. Consider uploading reports for the commit f567a18 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #751   +/-   ##
=======================================
  Coverage   88.07%   88.07%           
=======================================
  Files         131      131           
  Lines        2289     2289           
=======================================
  Hits         2016     2016           
  Misses        273      273           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.16.1 to 2.17.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.16.1...v2.17.0)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-rails-2.17.0 branch from 3147f8d to f567a18 Compare October 24, 2022 21:23
@nilsding
Copy link
Member

@dependabot merge

@dependabot dependabot bot merged commit ec760fc into main Oct 24, 2022
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-rails-2.17.0 branch October 24, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant