Support for Billing Client 6 #1209

MarkVillacampa · 2023-08-24T14:00:40Z

Bumping Billing client to 6.0.0

Deprecates...
- ProrationMode -> ReplacementMode
- GoogleProrationMode -> GoogleReplacementMode
Temporarily disables DEFERRED product change until backend support is ready.

codecov · 2023-08-24T14:15:41Z

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (395ca5f) 85.83% compared to head (2d37316) 85.51%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1209      +/-   ##
==========================================
- Coverage   85.83%   85.51%   -0.33%     
==========================================
  Files         186      187       +1     
  Lines        6319     6358      +39     
  Branches      918      923       +5     
==========================================
+ Hits         5424     5437      +13     
- Misses        546      567      +21     
- Partials      349      354       +5

Files	Coverage Δ
...tlin/com/revenuecat/purchases/PostReceiptHelper.kt	`94.31% <100.00%> (ø)`
.../com/revenuecat/purchases/PurchasesOrchestrator.kt	`81.70% <100.00%> (-1.78%)`	⬇️
...n/com/revenuecat/purchases/amazon/AmazonBackend.kt	`86.66% <ø> (ø)`
...lin/com/revenuecat/purchases/amazon/AmazonCache.kt	`85.71% <ø> (ø)`
...rchases/amazon/DefaultPurchasingServiceProvider.kt	`14.28% <ø> (ø)`
...azon/attribution/AmazonDeviceIdentifiersFetcher.kt	`100.00% <100.00%> (ø)`
...cat/purchases/amazon/handler/ProductDataHandler.kt	`89.65% <100.00%> (ø)`
...nuecat/purchases/amazon/handler/PurchaseHandler.kt	`88.88% <100.00%> (ø)`
...purchases/amazon/handler/PurchaseUpdatesHandler.kt	`91.66% <100.00%> (ø)`
...ses/amazon/listener/ProductDataResponseListener.kt	`0.00% <ø> (ø)`
... and 23 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

migrations/v7-MIGRATION.md

purchases/src/main/kotlin/com/revenuecat/purchases/PurchaseParams.kt

purchases/src/main/kotlin/com/revenuecat/purchases/common/Backend.kt

purchases/src/main/kotlin/com/revenuecat/purchases/models/GoogleProrationMode.kt

purchases/src/main/kotlin/com/revenuecat/purchases/models/GoogleReplacementMode.kt

purchases/src/main/kotlin/com/revenuecat/purchases/models/StoreTransaction.kt

api-tester/src/main/java/com/revenuecat/apitester/java/GoogleProrationModeAPI.java

api-tester/src/main/java/com/revenuecat/apitester/kotlin/PurchasesCommonAPI.kt

examples/purchase-tester/src/main/java/com/revenuecat/purchasetester/ConfigureFragment.kt

purchases/src/main/kotlin/com/revenuecat/purchases/PurchasesOrchestrator.kt

purchases/src/main/kotlin/com/revenuecat/purchases/google/BillingWrapper.kt

purchases/src/main/kotlin/com/revenuecat/purchases/models/GoogleProrationMode.kt

purchases/src/main/kotlin/com/revenuecat/purchases/models/GoogleReplacementMode.kt

purchases/src/test/java/com/revenuecat/purchases/PurchasesCommonTest.kt

purchases/src/testDefaults/kotlin/com/revenuecat/purchases/PurchasesTest.kt

api-tester/src/main/java/com/revenuecat/apitester/java/PurchasesCommonAPI.java

api-tester/src/main/java/com/revenuecat/apitester/kotlin/PurchasesCommonAPI.kt

api-tester/src/main/java/com/revenuecat/apitester/java/PurchasesCommonAPI.java

api-tester/src/main/java/com/revenuecat/apitester/kotlin/GoogleProrationModeAPI.kt

purchases/src/main/kotlin/com/revenuecat/purchases/PurchaseParams.kt

purchases/src/main/kotlin/com/revenuecat/purchases/common/HTTPClient.kt

purchases/src/main/kotlin/com/revenuecat/purchases/google/errors.kt

purchases/src/main/kotlin/com/revenuecat/purchases/models/StoreTransaction.kt

api-tester/src/main/java/com/revenuecat/apitester/java/GoogleProrationModeAPI.java

api-tester/src/main/java/com/revenuecat/apitester/kotlin/GoogleProrationModeAPI.kt

migrations/v7-MIGRATION.md

purchases/src/test/java/com/revenuecat/purchases/PurchasesCommonTest.kt

tonidero

Looks good. Maybe we should remove the commented out code temporarily as Andy suggested.

migrations/v7-MIGRATION.md

MarkVillacampa · 2023-09-27T12:35:54Z

Commit f4b99bd was cherry-picked from PR #1289

…ges in BC6

aboedo · 2023-09-27T13:44:43Z

migrations/v7-MIGRATION.md

+However, there is a behavior change in the "DEFERRED" replacement mode. Previously, a purchase would only occur after the
+product change. In BC6, the new purchase occurs place immediately, while the product change becomes effective when the old
+item expires. Until we can properly support this new behaviour, we have disabled the "DEFERRED" replacement mode and it 
+will be added back in a future release of the SDK. 


Let's make it the implications for a developer super explicit here: I might not know whether this affects me at all, and it most likely doesn't.

Maybe something like

If your app supports product changes using DEFERRED replacement mode (link to docs), then you can either stick with the previous major version until support for DEFERRED is re-introduced in this major version, or you can remove DEFERRED replacement options from your app.

If your app doesn't currently use DEFERRED replacement modes, then you should be safe to upgrade to this version without changes in behavior.

or maybe flipping the order of those since DEFERRED isn't very widely used

aboedo · 2023-09-27T13:46:24Z

looks good! Left one minor note, good to go otherwise

@MarkVillacampa

### Breaking Changes * Support for Billing Client 6 (#1209) via Mark Villacampa (@MarkVillacampa) * Bump minimum sdk version to Android 4.4 (API level 19) (#1265) via Mark Villacampa (@MarkVillacampa) * in app messages support (#1290) via Andy Boedo (@aboedo) ### Bugfixes * Add `awaitRestore` to customEntitlementComputation library (#1275) via Toni Rico (@tonidero) ### Other Changes * Future-proof in-app message APIs in case new types are added (#1293) via Toni Rico (@tonidero) * `Code style`: enabled `ALLOW_TRAILING_COMMA` (#1280) via NachoSoto (@NachoSoto)

… to Billing Client 6 (#506) Refer to RevenueCat/purchases-android#1209 for more information

… to Billing Client 6 (#425) Refer to RevenueCat/purchases-android#1209 for more information

… to Billing Client 6 (#821) Refer to RevenueCat/purchases-android#1209 for more information

MarkVillacampa added breaking Changes that are breaking dependencies Changes on external dependencies labels Aug 24, 2023

MarkVillacampa force-pushed the bc6-support-new branch from 14619ac to afb74ab Compare August 24, 2023 14:39

vegaro reviewed Aug 24, 2023

View reviewed changes

migrations/v7-MIGRATION.md Show resolved Hide resolved

migrations/v7-MIGRATION.md Show resolved Hide resolved

migrations/v7-MIGRATION.md Show resolved Hide resolved

purchases/src/main/kotlin/com/revenuecat/purchases/PurchaseParams.kt Show resolved Hide resolved

vegaro reviewed Aug 24, 2023

View reviewed changes

joshdholtz mentioned this pull request Aug 29, 2023

[WIP] BC6 Support #1001

Closed

MarkVillacampa force-pushed the bc6-support-new branch from 543856e to 3173653 Compare September 19, 2023 17:38

MarkVillacampa mentioned this pull request Sep 19, 2023

Bump minimum sdk version to Android 4.4 (API level 19) #1265

Merged

NachoSoto reviewed Sep 21, 2023

View reviewed changes

tonidero reviewed Sep 22, 2023

View reviewed changes

vegaro reviewed Sep 25, 2023

View reviewed changes

purchases/src/main/kotlin/com/revenuecat/purchases/models/StoreTransaction.kt Outdated Show resolved Hide resolved

vegaro mentioned this pull request Sep 25, 2023

Made some classes and functions internal #1289

Closed

vegaro approved these changes Sep 25, 2023

View reviewed changes

aboedo reviewed Sep 25, 2023

View reviewed changes

tonidero reviewed Sep 26, 2023

View reviewed changes

migrations/v7-MIGRATION.md Outdated Show resolved Hide resolved

MarkVillacampa force-pushed the bc6-support-new branch from 3c6cef9 to ca82851 Compare September 27, 2023 12:32

MarkVillacampa added 8 commits September 27, 2023 15:17

Support for Billing Client 6

922006e

Update purchase tester to use replacement mode apis

29ad763

change visibility to internal

708e37e

fix parameter

2a7d49d

disable deferred proration mode

a3f7c16

Add note about temporarily removed DEFERRED proration mode

84a90d2

fix test

23f44f1

Add back isPersonalizedPrice

3f05900

MarkVillacampa and others added 9 commits September 27, 2023 15:17

Add back prorationMode field to StoreTransaction

4c76968

Add more ReplacementMode tests

7ee9a2e

remove leftovers

25e7697

add back extra isPersonalizedPrice

076cb31

test deprecated constructor

d71c3af

Improve deprecation messages

5356c3d

remove commented out DEFERRED proration mode code

6e8ffc0

Remove old API deprecations from the migration guide and explain chan…

941e7ff

…ges in BC6

changes some classes to internal

9e2f693

MarkVillacampa force-pushed the bc6-support-new branch from f4b99bd to 9e2f693 Compare September 27, 2023 13:17

aboedo reviewed Sep 27, 2023

View reviewed changes

MarkVillacampa added 2 commits September 27, 2023 15:54

lint

2c441ab

Clarified migration guide

2d37316

MarkVillacampa merged commit 468a850 into main Sep 27, 2023
5 checks passed

MarkVillacampa deleted the bc6-support-new branch September 27, 2023 14:29

MarkVillacampa mentioned this pull request Sep 27, 2023

Release/7.0.0 #1296

Merged

MarkVillacampa added a commit to RevenueCat/purchases-hybrid-common that referenced this pull request Oct 3, 2023

Temporarily remode DEFERRED proration mode in preparation for upgrade…

d7bc2ab

… to Billing Client 6 (#506) Refer to RevenueCat/purchases-android#1209 for more information

tonidero pushed a commit to RevenueCat/cordova-plugin-purchases that referenced this pull request Oct 4, 2023

Temporarily remode DEFERRED proration mode in preparation for upgrade…

5f7ecf0

… to Billing Client 6 (#425) Refer to RevenueCat/purchases-android#1209 for more information

MarkVillacampa added a commit to RevenueCat/purchases-flutter that referenced this pull request Oct 5, 2023

Temporarily remode DEFERRED proration mode in preparation for upgrade…

19357b8

… to Billing Client 6 (#821) Refer to RevenueCat/purchases-android#1209 for more information

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for Billing Client 6 #1209

Support for Billing Client 6 #1209

MarkVillacampa commented Aug 24, 2023 •

edited

Loading

codecov bot commented Aug 24, 2023 •

edited

Loading

tonidero left a comment

MarkVillacampa commented Sep 27, 2023

aboedo Sep 27, 2023 •

edited

Loading

aboedo Sep 27, 2023

aboedo commented Sep 27, 2023

Support for Billing Client 6 #1209

Support for Billing Client 6 #1209

Conversation

MarkVillacampa commented Aug 24, 2023 • edited Loading

Bumping Billing client to 6.0.0

codecov bot commented Aug 24, 2023 • edited Loading

Codecov Report

tonidero left a comment

Choose a reason for hiding this comment

MarkVillacampa commented Sep 27, 2023

aboedo Sep 27, 2023 • edited Loading

Choose a reason for hiding this comment

aboedo Sep 27, 2023

Choose a reason for hiding this comment

aboedo commented Sep 27, 2023

MarkVillacampa commented Aug 24, 2023 •

edited

Loading

codecov bot commented Aug 24, 2023 •

edited

Loading

aboedo Sep 27, 2023 •

edited

Loading