Add awaitRestore to customEntitlementComputation library
#1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
commented
Sep 21, 2023
| @@ -229,4 +231,113 @@ internal class PurchasesCoroutinesCommonTest : BasePurchasesTest() { | |||
| } | |||
|
|
|||
| // endregion | |||
|
|
|||
| // region awaitRestore | |||
There was a problem hiding this comment.
This is just moving the tests. No changes.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1275 +/- ##
=======================================
Coverage 85.94% 85.94%
=======================================
Files 184 184
Lines 6274 6274
Branches 911 911
=======================================
Hits 5392 5392
Misses 536 536
Partials 346 346
☔ View full report in Codecov by Sentry. |
vegaro
approved these changes
Sep 21, 2023
tonidero
deleted the
add-await-restore-custom-entitlement-computation-library
branch
Merged
MarkVillacampa
added a commit
that referenced
this pull request
Sep 28, 2023
### Breaking Changes * Support for Billing Client 6 (#1209) via Mark Villacampa (@MarkVillacampa) * Bump minimum sdk version to Android 4.4 (API level 19) (#1265) via Mark Villacampa (@MarkVillacampa) * in app messages support (#1290) via Andy Boedo (@aboedo) ### Bugfixes * Add `awaitRestore` to customEntitlementComputation library (#1275) via Toni Rico (@tonidero) ### Other Changes * Future-proof in-app message APIs in case new types are added (#1293) via Toni Rico (@tonidero) * `Code style`: enabled `ALLOW_TRAILING_COMMA` (#1280) via NachoSoto (@NachoSoto)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We moved the restore purchases functionality to the customEntitlementComputation library in #1211 but we didn't make the coroutines version available as well. This fixes that.