-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OfferingsFactory
: debug logs when creating Offerings
#1576
Conversation
While debugging an issue, I realized that the SDK never prints anything after fetching products. This should provide more visibility on the `Offerings` initialization.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1576 +/- ##
=======================================
Coverage 83.72% 83.73%
=======================================
Files 218 218
Lines 7246 7248 +2
Branches 1007 1007
=======================================
+ Hits 6067 6069 +2
Misses 788 788
Partials 391 391 ☔ View full report in Codecov by Sentry. |
@@ -52,6 +52,7 @@ internal class OfferingsFactory( | |||
), | |||
) | |||
} else { | |||
log(LogIntent.DEBUG, OfferingStrings.CREATED_OFFERINGS.format(offerings)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be verbose? Seems like this might be a big log in some cases.
purchases/src/main/kotlin/com/revenuecat/purchases/common/offerings/OfferingsFactory.kt
Outdated
Show resolved
Hide resolved
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: fix template 5 title alignment (#1585) via NachoSoto (@NachoSoto) * `Paywalls`: replace `TextAlign.Left` with `TextAlign.Start` to better support RTL (#1584) via NachoSoto (@NachoSoto) * Paywall views: Support updating options state after initial layout (#1582) via Toni Rico (@tonidero) * `Paywalls`: improve `PaywallData.configForLocale()` disambiguation (#1579) via NachoSoto (@NachoSoto) ### Dependency Updates * Bump fastlane-plugin-revenuecat_internal from `e6ba247` to `9c82c7a` (#1583) via dependabot[bot] (@dependabot[bot]) ### Other Changes * `OfferingsFactory`: debug logs when creating `Offerings` (#1576) via NachoSoto (@NachoSoto) * `Paywalls`: log error when creating `PaywallState.Error` (#1574) via NachoSoto (@NachoSoto) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
While debugging an issue, I realized that the SDK never prints anything after fetching products.
This should provide more visibility on the
Offerings
initialization.