Paywalls: improve PaywallData.configForLocale() disambiguation
#1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
force-pushed
the
paywalls-chinese-localization
branch
from
a881294
to
7cc8016
Compare
iOS equivalent: RevenueCat/purchases-ios#3605 See also https://medium.com/fabiohub/chinese-locale-in-android-part-2-d1cfe87b3fb2: > In order to support zh-rHK, zh-rHK_#Hant and zh-rHK_#Hans to fall back correctly on both pre & post Android 7.0 devices, you need these resources: - `zh-rHK` (Traditional Chinese) - `zh-rTW` (Traditional Chinese) - `zh` (Simplified Chinese)
NachoSoto
force-pushed
the
paywalls-chinese-localization
branch
from
7cc8016
to
091db37
Compare
NachoSoto
force-pushed
the
paywalls-chinese-localization
branch
from
4aac494
to
df4885d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1579 +/- ##
==========================================
- Coverage 83.73% 83.71% -0.02%
==========================================
Files 218 218
Lines 7248 7260 +12
Branches 1007 1011 +4
==========================================
+ Hits 6069 6078 +9
Misses 788 788
- Partials 391 394 +3 ☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
Jan 29, 2024
|
Yeah I forgot to mention that the method in iOS does this automatically, but I couldn't get these tests to pass without encoding that. |
vegaro
pushed a commit
that referenced
this pull request
Feb 5, 2024
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: fix template 5 title alignment (#1585) via NachoSoto (@NachoSoto) * `Paywalls`: replace `TextAlign.Left` with `TextAlign.Start` to better support RTL (#1584) via NachoSoto (@NachoSoto) * Paywall views: Support updating options state after initial layout (#1582) via Toni Rico (@tonidero) * `Paywalls`: improve `PaywallData.configForLocale()` disambiguation (#1579) via NachoSoto (@NachoSoto) ### Dependency Updates * Bump fastlane-plugin-revenuecat_internal from `e6ba247` to `9c82c7a` (#1583) via dependabot[bot] (@dependabot[bot]) ### Other Changes * `OfferingsFactory`: debug logs when creating `Offerings` (#1576) via NachoSoto (@NachoSoto) * `Paywalls`: log error when creating `PaywallState.Error` (#1574) via NachoSoto (@NachoSoto) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS equivalent: RevenueCat/purchases-ios#3605
See also https://medium.com/fabiohub/chinese-locale-in-android-part-2-d1cfe87b3fb2: