Add missing forwarding to PaywallListener.onPurchaseCancelled
#1590
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
approved these changes
Feb 1, 2024
| @@ -73,6 +73,7 @@ open class PaywallFooterView : FrameLayout { | |||
| override fun onRestoreStarted() { listener?.onRestoreStarted() } | |||
| override fun onRestoreCompleted(customerInfo: CustomerInfo) { listener?.onRestoreCompleted(customerInfo) } | |||
| override fun onRestoreError(error: PurchasesError) { listener?.onRestoreError(error) } | |||
| override fun onPurchaseCancelled() { listener?.onPurchaseCancelled() } | |||
There was a problem hiding this comment.
Total nitpick but I would move it up to be with the other onPurchase... callbacks
| @@ -73,6 +73,7 @@ class PaywallView : FrameLayout { | |||
| override fun onRestoreStarted() { listener?.onRestoreStarted() } | |||
| override fun onRestoreCompleted(customerInfo: CustomerInfo) { listener?.onRestoreCompleted(customerInfo) } | |||
| override fun onRestoreError(error: PurchasesError) { listener?.onRestoreError(error) } | |||
| override fun onPurchaseCancelled() { listener?.onPurchaseCancelled() } | |||
vegaro
pushed a commit
that referenced
this pull request
Feb 6, 2024
**This is an automatic release.** ### New Features * [EXTERNAL] Exposing fontprovider setter in `PaywallView` and `PaywallFooterView` by @Jjastiny (#1589) via Toni Rico (@tonidero) ### RevenueCatUI * `Paywalls`: add 4 new variables (#1599) via NachoSoto (@NachoSoto) ### Bugfixes * Catch Exception instead of only IllegalArgumentException when decoding paywallData (#1601) via Cesar de la Vega (@vegaro) * Revert making PaywallFooterView an AbstractComposeView (#1598) via Cesar de la Vega (@vegaro) * Add missing forwarding to `PaywallListener.onPurchaseCancelled` (#1590) via Cesar de la Vega (@vegaro) ### Dependency Updates * Bump danger from 9.4.2 to 9.4.3 (#1597) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Update CHANGELOG with 6.9.6 release notes (#1596) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing calling
onPurchaseCancelledwhen creating an internal PaywallListener