Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paywalls: add 4 new variables #1599

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Paywalls: add 4 new variables #1599

merged 1 commit into from
Feb 6, 2024

Conversation

NachoSoto
Copy link
Contributor

Android equivalent of RevenueCat/purchases-ios#3629

Added:

  • price_per_period_full
  • total_price_and_per_month_full
  • sub_period_length
  • sub_period_abbreviated

Android equivalent of RevenueCat/purchases-ios#3629

- `price_per_period_full`
- `total_price_and_per_month_full`
- `sub_period_length`
- `sub_period_abbreviated`
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (506b537) 83.71% compared to head (3dbd67e) 83.71%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1599   +/-   ##
=======================================
  Coverage   83.71%   83.71%           
=======================================
  Files         218      218           
  Lines        7260     7260           
  Branches     1011     1011           
=======================================
  Hits         6078     6078           
  Misses        788      788           
  Partials      394      394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@NachoSoto NachoSoto merged commit 854ee2f into main Feb 6, 2024
9 checks passed
@NachoSoto NachoSoto deleted the paywalls-new-variables branch February 6, 2024 14:39
vegaro pushed a commit that referenced this pull request Feb 6, 2024
**This is an automatic release.**

### New Features
* [EXTERNAL] Exposing fontprovider setter in `PaywallView` and
`PaywallFooterView` by @Jjastiny (#1589) via Toni Rico (@tonidero)
### RevenueCatUI
* `Paywalls`:  add 4 new variables (#1599) via NachoSoto (@NachoSoto)
### Bugfixes
* Catch Exception instead of only IllegalArgumentException when decoding
paywallData (#1601) via Cesar de la Vega (@vegaro)
* Revert making PaywallFooterView an AbstractComposeView (#1598) via
Cesar de la Vega (@vegaro)
* Add missing forwarding to `PaywallListener.onPurchaseCancelled`
(#1590) via Cesar de la Vega (@vegaro)
### Dependency Updates
* Bump danger from 9.4.2 to 9.4.3 (#1597) via dependabot[bot]
(@dependabot[bot])
### Other Changes
* Update CHANGELOG with 6.9.6 release notes (#1596) via Toni Rico
(@tonidero)

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants