PaywallViewController: new initializer with Offering identifier
#3587
Conversation
|
|
||
| // MARK: - | ||
|
|
||
| internal extension Optional where Wrapped == String { |
There was a problem hiding this comment.
Moved this to String+Extensions since it makes more sense there. This file is also now sym-linked so it can be used by RevenueCatUI.
NachoSoto
force-pushed
the
paywall-view-load-by-offering-2
branch
from
2cc24a3
to
39b0c76
Compare
| @@ -56,14 +50,45 @@ public class PaywallViewController: UIViewController { | |||
| /// `Offerings.current` will be used by default. | |||
| /// - Parameter fonts: An optional ``PaywallFontProvider``. | |||
| /// - Parameter displayCloseButton: Set this to `true` to automatically include a close button. | |||
| public init( | |||
| public convenience init( | |||
There was a problem hiding this comment.
just a question I have, there's only one @objc annotated method in this file, but we don't use it in phc, because it's written in Swift... is it exposed for folks that are using objective c? If so, should we expose another constructor?
There was a problem hiding this comment.
Also in the docs of this constructor it says "an optional PaywallFontProvider", but it's not optional
There was a problem hiding this comment.
is it exposed for folks that are using objective c?
Yeah that's correct, because PaywallFontProvider isn't available in Swift.
I'll add another one with offering identifier for ObjC
There was a problem hiding this comment.
And fixed the docs, thanks!
There was a problem hiding this comment.
Actually I think I'm not going to do that. The ideal way is passing an Offering to minimize the chances that you'll pass something that won't be found. The offeringIdentifier one is just for us for the hybrids. Other users should pass Offerings
Depends on #3586. This will be used by the hybrid SDKs to be able to load paywalls with an offering identifier.
NachoSoto
force-pushed
the
paywall-view-load-by-offering-2
branch
from
39b0c76
to
fe45714
Compare
**This is an automatic release.** ### RevenueCatUI * `PaywallViewController`: new initializer with `Offering` identifier (#3587) via NachoSoto (@NachoSoto) * `Paywalls`: improve template 5 layout for long product names (#3589) via NachoSoto (@NachoSoto) ### Other Changes * `Paywalls`: extracted `PaywallViewConfiguration` (#3586) via NachoSoto (@NachoSoto) * `CircleCI`: avoid installing `Xcodes` when not needed (#3585) via NachoSoto (@NachoSoto) * `CircleCI`: change all jobs to M1 (#3140) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com> Co-authored-by: NachoSoto <NachoSoto@users.noreply.github.com>
…tifier (iOS) (#666) Depends on RevenueCat/purchases-ios#3587.
…tifier (iOS) (#675) Depends on RevenueCat/purchases-ios#3587. Reopened #666.
Depends on #3586.
This will be used by the hybrid SDKs to be able to load paywalls with an offering identifier.