CircleCI: change all jobs to M1
#3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated deadline per CircleCI's update. |
NachoSoto
force-pushed
the
nacho/testing-circleci-m1
branch
2 times, most recently
from
d0b6f5c
to
413840d
Compare
NachoSoto
changed the title
CircleCI: change all jobs to M1CircleCI: change all jobs to M1
MarkVillacampa
approved these changes
Jan 12, 2024
|
Need to verify release checks and installation tests |
NachoSoto
force-pushed
the
nacho/testing-circleci-m1
branch
from
5a9a2ee
to
cf121cd
Compare
NachoSoto
commented
Jan 12, 2024
|
Glad I enabled everything, gotta fix release-checks / framework creation on M1, probably remove the Carthage workaround script. |
NachoSoto
force-pushed
the
nacho/testing-circleci-m1
branch
from
cf121cd
to
91de160
Compare
NachoSoto
force-pushed
the
nacho/testing-circleci-m1
branch
from
91de160
to
05552f5
Compare
Fixes https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/17208/workflows/729d01a6-d644-446c-8514-80b54177ff43/jobs/162052/tests With #3140 and faster executors in CI, it's become clear that this test is very flaky because it relies on requests not finishing quickly enough. For the first test, specifying a priority should ensure that tasks don't start running until they're all enqueued. For the second test, it's important that if the first `CustomerInfo` request had finished, we don't make a second one, which would make the test fail.
NachoSoto
force-pushed
the
nacho/testing-circleci-m1
branch
from
6e1af17
to
f4a690a
Compare
NachoSoto
force-pushed
the
nacho/testing-circleci-m1
branch
from
f4a690a
to
6dbe2bc
Compare
NachoSoto
commented
Jan 18, 2024
| @@ -31,42 +31,6 @@ class OtherIntegrationTests: BaseBackendIntegrationTests { | |||
| expect(info.isComputedOffline) == false | |||
| } | |||
|
|
|||
| func testGetCustomerInfoMultipleTimesInParallel() async throws { | |||
There was a problem hiding this comment.
I can't figure out a way to write this test in a way that can't suffer from race conditions.
There was a problem hiding this comment.
Luckily this is already covered by unit tests.
NachoSoto
added a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Jan 19, 2024
See also RevenueCat/purchases-ios#3140. This also updates Xcode 15.0 to 15.2.
NachoSoto
added a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Jan 19, 2024
See also RevenueCat/purchases-ios#3140. This also updates Xcode 15.0 to 15.2.
NachoSoto
added a commit
that referenced
this pull request
Jan 23, 2024
**This is an automatic release.** ### RevenueCatUI * `PaywallViewController`: new initializer with `Offering` identifier (#3587) via NachoSoto (@NachoSoto) * `Paywalls`: improve template 5 layout for long product names (#3589) via NachoSoto (@NachoSoto) ### Other Changes * `Paywalls`: extracted `PaywallViewConfiguration` (#3586) via NachoSoto (@NachoSoto) * `CircleCI`: avoid installing `Xcodes` when not needed (#3585) via NachoSoto (@NachoSoto) * `CircleCI`: change all jobs to M1 (#3140) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com> Co-authored-by: NachoSoto <NachoSoto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCIis deprecating Intel machines, so we need to get this working: https://discuss.circleci.com/t/macos-intel-support-deprecation-in-january-2024/48718Deadline for this is January 31 2024.New deadline is 28 June 2024.Note that Codecov isn't compatible (yet?) so I'm turning it off for now.