Paywalls: extracted PaywallViewConfiguration
#3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of parameters was already very large. This refactor combines the different values into its own type. This is also a preliminary refactor to be able to configure a paywall with an offering identifier instead of an offering, which will be used by the hybrid SDKs.
NachoSoto
commented
Jan 19, 2024
Comment on lines
+18
to
+20
| var mode: PaywallViewMode = .default | ||
| var fonts: PaywallFontProvider = DefaultPaywallFontProvider() | ||
| var displayCloseButton: Bool = false |
There was a problem hiding this comment.
The default value for these is now in a single place instead of being duplicated in several places.
NachoSoto
added a commit
that referenced
this pull request
Jan 19, 2024
Depends on #3586. This will be used by the hybrid SDKs to be able to load paywalls with an offering identifier.
NachoSoto
added a commit
that referenced
this pull request
Jan 19, 2024
Depends on #3586. This will be used by the hybrid SDKs to be able to load paywalls with an offering identifier.
NachoSoto
added a commit
that referenced
this pull request
Jan 19, 2024
Depends on #3586. This will be used by the hybrid SDKs to be able to load paywalls with an offering identifier.
vegaro
approved these changes
Jan 22, 2024
tonidero
reviewed
Jan 22, 2024
|
|
||
| /// Parameters needed to configure a ``PaywallView``. | ||
| @available(iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0, *) | ||
| struct PaywallViewConfiguration { |
There was a problem hiding this comment.
In android, this would be similar to PaywallOptions, which is public and it's how developers can customize most things for the paywall. We used the builder pattern there, but I'm not sure if that's so common in swift.
There was a problem hiding this comment.
Yeah we could think about exposing this (and only the public types). We can do that in a separate PR.
tonidero
approved these changes
Jan 22, 2024
NachoSoto
added a commit
that referenced
this pull request
Jan 22, 2024
Depends on #3586. This will be used by the hybrid SDKs to be able to load paywalls with an offering identifier.
NachoSoto
added a commit
that referenced
this pull request
Jan 23, 2024
**This is an automatic release.** ### RevenueCatUI * `PaywallViewController`: new initializer with `Offering` identifier (#3587) via NachoSoto (@NachoSoto) * `Paywalls`: improve template 5 layout for long product names (#3589) via NachoSoto (@NachoSoto) ### Other Changes * `Paywalls`: extracted `PaywallViewConfiguration` (#3586) via NachoSoto (@NachoSoto) * `CircleCI`: avoid installing `Xcodes` when not needed (#3585) via NachoSoto (@NachoSoto) * `CircleCI`: change all jobs to M1 (#3140) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com> Co-authored-by: NachoSoto <NachoSoto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of parameters was already very large. This refactor combines the different values into its own type.
This is also a preliminary refactor to be able to configure a paywall with an offering identifier instead of an offering, which will be used by the hybrid SDKs.