New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graceful fossil error handling #3951
Conversation
The lead programmer for Thrive is currently on break until 2023-01-02. Until then other programmers will try to make pull request reviews, but please be patient if your PR is not getting reviewed. PRs maybe merged after multiple programmers have approved the changes (especially making sure to ensure style guide conformance and gameplay testing are good). But PRs may need to wait until the lead programmer is back from the break. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still like the approach of allowing corrupt entries just for the sake of telling players they have corrupt fossils but, this is good enough I guess.
It would certainly be possible to update that in future using a null check to display something else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good, as for now, this looks fine to me
Brief Description of What This PR Does
Ignores corrupt fossil files to prevent crashes when opening the Thriveopedia.
I went for the nuclear option of just wrapping the whole loading process in a try-catch block and printing the error. That may lead to error spam if a user with a corrupt fossil repeatedly opens and closes the Thriveopedia.
Related Issues
Closes #3861
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.