Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Lib.Harmony from 2.2.2 to 2.3.1.1 #4928

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 4, 2024

Bumps Lib.Harmony from 2.2.2 to 2.3.1.1.

Release notes

Sourced from Lib.Harmony's releases.

Harmony 2.3.1.1

This releases fixes a regression for .Net Standard projects

Harmony 2.3.1

v2.3.1 fixes:

  • Dependency problem / duplicate type errors that we introduced with v2.3
  • Better dead code handling #584
  • new Lib.Harmony.Ref for projects targeting .NET Standard 2.0

Harmony Thin 2.3.0.1

This update updates Harmony Thin only and makes the dependency on MonoMod.Core public so it is included in transitive dependencies. No other changes.

Harmony 2.3

We have been preparing and testing this for months and I want to specially mention the the help of our HUGE community on this release. Harmony is downloaded over 800 times a day and has over 1.6 million downloads on Nuget and a Discord server with over 2100 members.

New core engine Harmony 2.3 now uses MonoMod.Core v1.1 (part of https://github.com/MonoMod) which is a rewrite of the low level back-end for patching .NET methods.

Support for newer .NET versions .NET 7 and .NET 8 support is finally here

Tests via GitHub Actions Harmony is now tested on Azure and GitHub and thus we can start testing macOS and other fancy combinations: https://github.com/pardeike/Harmony/actions/workflows/test.yml

Fat and Thin versions Harmony is now released in two packages on nuget: Lib.Harmony and Lib.Harmony.Thin. The thin version does not embed dependencies and thus allows you to manage them yourself. The normal version embeds them as internal types and works as usual as a standalone dll. https://www.nuget.org/packages/Lib.Harmony https://www.nuget.org/packages/Lib.Harmony.Thin

Changes

  • Support GenericInstance types in inline method signatures 1960f575bddd04e9de617aa6af8b284c8383bb30
  • adds better detection for methods that end in dead code 7b5158aefb1aba88827fa598d5e37e67d1a58380
  • Merge pull request #565 from Zetrith 03b642613f00ac8a7290df824785f07a357c6852
  • Error in exported Godot Engine build when attempting to patch method #562
  • Regression with methods ending in throw + ret e63e183e315c30a4cc44db93a9484cd77d9492a6
  • fixes a bug where Harmony calls TargetMethods() always twice 7ab508c95e336619d0b77eb0918d74ac10fbcc2c
  • Native async patching is not available in .NET Standard or .NET #533
  • adds IEnumerable.Matches() b9206db8abbe670f88e1fbe4a71f0986765f05ff
  • Uses PlatformTriple.Current.GetIdentifiable for a user submitted MethodInfo
  • fixes more unix tests
  • patches Assembly.GetExecutingAssembly internally
  • Improves http_client tests cda2226d2a9547c24f84521cfd3a894aea3a62f4
  • adds useful linux test shortcut c2586e7d0b2e2a73333b928eb0043e7c8542268a
  • adds null/zero return clarifcations for TargetMethod/s #544
  • fixes CodeMatch(()=>... 7e4183ee30b886ec2f862412a70b92d2a16622cf
  • Documentation Auxiliary Methods - Attribute spelling issue. Plus logic fix. #557
  • adds InnerTypes() and extensions for AccessTool methods on type Type d916a300d1e13b171b9a33fcf5dd7eab292d13ca
  • code cleanup, net8.0, optional ret code for methods ending in throw

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [Lib.Harmony](https://github.com/pardeike/Harmony) from 2.2.2 to 2.3.1.1.
- [Release notes](https://github.com/pardeike/Harmony/releases)
- [Commits](pardeike/Harmony@v2.2.2.0...v2.3.1.1)

---
updated-dependencies:
- dependency-name: Lib.Harmony
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/Lib.Harmony-2.3.1.1 branch from 8519695 to 3456584 Compare March 5, 2024 06:38
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine, but should check if this now stops the game process from crashing when initializing harmony.

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 14, 2024

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@hhyyrylainen
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 14, 2024

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

1 similar comment
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 18, 2024

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 19, 2024

Looks like Lib.Harmony is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Mar 19, 2024
@dependabot dependabot bot deleted the dependabot/nuget/Lib.Harmony-2.3.1.1 branch March 19, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant