Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor using modular code with ES6 #17

Closed
jwildfire opened this issue Jul 1, 2016 · 8 comments
Closed

Refactor using modular code with ES6 #17

jwildfire opened this issue Jul 1, 2016 · 8 comments
Assignees
Milestone

Comments

@jwildfire
Copy link
Contributor

And then implement a build process using node/npm/rollup/babel similar to the one described in webcharts-wrappers-boilerplate

@jwildfire jwildfire modified the milestone: 3.0.0 Jul 1, 2016
@samussiah samussiah self-assigned this Jul 27, 2016
@jwildfire
Copy link
Contributor Author

@samussiah Let's try to follow @nbryant's lead on modularization and use rollup + babel. Checkout the package.json and scripts folder for the safety explorer renderers as an example. The boilerplate wiki might provide some useful context as well.

@samussiah
Copy link
Contributor

samussiah commented Aug 1, 2016

It's done. It's modularized. All recursive references and undeclared variables have been corrected. exhales tiredly

@samussiah
Copy link
Contributor

http://bl.ocks.org/samussiah/raw/90e524b9ef2fdf8214d491aaca4cd3b3/

@brittsikora
Copy link

@jwildfire - how do I test this?

@jwildfire
Copy link
Contributor Author

@brittsikora I (or another dev) can do a code review on the pull request to test.

@brittsikora
Copy link

Should I assign this to you or perhaps Shane?

@jwildfire
Copy link
Contributor Author

Lots more work done here. Should be close to done. See #29 for details.

@jwildfire
Copy link
Contributor Author

Implemented in #29, so going to go ahead and close. Thanks again for all the good work, @samussiah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants