-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor using modular code with ES6 #17
Comments
@samussiah Let's try to follow @nbryant's lead on modularization and use rollup + babel. Checkout the package.json and scripts folder for the safety explorer renderers as an example. The boilerplate wiki might provide some useful context as well. |
It's done. It's modularized. All recursive references and undeclared variables have been corrected. exhales tiredly |
@jwildfire - how do I test this? |
@brittsikora I (or another dev) can do a code review on the pull request to test. |
Should I assign this to you or perhaps Shane? |
Lots more work done here. Should be close to done. See #29 for details. |
Implemented in #29, so going to go ahead and close. Thanks again for all the good work, @samussiah! |
And then implement a build process using node/npm/rollup/babel similar to the one described in webcharts-wrappers-boilerplate
The text was updated successfully, but these errors were encountered: