Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Angular 7 #8

Open
antoinedelia opened this issue Mar 20, 2019 · 2 comments
Open

Compatibility with Angular 7 #8

antoinedelia opened this issue Mar 20, 2019 · 2 comments

Comments

@antoinedelia
Copy link

When I'm installing the module, I get the following warnings:

npm WARN ng-feedback@1.1.8 requires a peer of @angular/common@^6.0.0-rc.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ng-feedback@1.1.8 requires a peer of @angular/core@^6.0.0-rc.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.

I currently have:

"@angular/common": "~7.2.9"
"@angular/core": "~7.2.9"

It would be nice to update the dependencies to support Angular 7 and get rid of these warnings.

@anushka-panagar
Copy link

Try removing the node modules or uninstall the dependencies and try reinstalling again. Clear cache as well after removing node modules from the directory.

@demisx
Copy link

demisx commented Oct 17, 2019

I am not sure how reinstalling can help here. The package is clearly stating that its peer dependency is Angular 6, but you have Angular 7 installed. Thus, the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants