Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gtk bugs #233

Closed
Riey opened this issue Feb 10, 2021 · 0 comments · Fixed by #241
Closed

Fix gtk bugs #233

Riey opened this issue Feb 10, 2021 · 0 comments · Fixed by #241
Labels
bug Something isn't working D-Normal Normal P-High T-GTK wontfix This will not be worked on
Milestone
1.0.0

Comments

@Riey
Copy link
Owner

Riey commented Feb 10, 2021

  • It's unclear why this bench need esc without esc, last character is not commited
  • bypass function never used
  • forwared event only triggered from commit_bypass so it could be just return false rather than call commit_event

    kime/src/frontends/gtk2/src/immodule.c

    Line 152 in 46cce01

    return commit_event(ctx, state, keyval);
@Riey Riey added bug Something isn't working P-High T-GTK improve labels Feb 10, 2021
@Riey Riey added this to the 1.0.0 milestone Feb 10, 2021
@Riey Riey added the D-Normal Normal label Feb 10, 2021
This was referenced Feb 11, 2021
Merged
Merged
@Riey Riey added the wontfix This will not be worked on label Feb 11, 2021
@Riey Riey closed this as completed in #241 Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working D-Normal Normal P-High T-GTK wontfix This will not be worked on
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Refactor GTK Riey/kime
1 participant
@Riey