feat(typescript)!: add consistent type import and export related rules

resolves #55
RightCapitalHQ · Nov 27, 2023 · 4d07ffa · 4d07ffa
1 parent baeddd1
commit 4d07ffa
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 0 deletions.
diff --git a/packages/eslint-config-typescript/index.js b/packages/eslint-config-typescript/index.js
@@ -99,5 +99,19 @@ module.exports = {
         typedefs: false,
       },
     ],
+
+    // https://github.com/RightCapitalHQ/frontend-style-guide/issues/55
+    '@typescript-eslint/consistent-type-imports': [
+      'error',
+      {
+        prefer: 'type-imports',
+        fixStyle: 'inline-type-imports',
+      },
+    ],
+    '@typescript-eslint/consistent-type-exports': [
+      'error',
+      { fixMixedExportsWithInlineTypeSpecifier: true },
+    ],
+    '@typescript-eslint/no-import-type-side-effects': 'error',
   },
 };
diff --git a/specs/eslint/__snapshots__/config-snapshot.test.ts.snap b/specs/eslint/__snapshots__/config-snapshot.test.ts.snap
@@ -2215,6 +2215,19 @@ exports[`resolved config matches snapshot typescript.ts 1`] = `
     "@typescript-eslint/comma-spacing": [
       "off",
     ],
+    "@typescript-eslint/consistent-type-exports": [
+      "error",
+      {
+        "fixMixedExportsWithInlineTypeSpecifier": true,
+      },
+    ],
+    "@typescript-eslint/consistent-type-imports": [
+      "error",
+      {
+        "fixStyle": "inline-type-imports",
+        "prefer": "type-imports",
+      },
+    ],
     "@typescript-eslint/func-call-spacing": [
       "off",
     ],
@@ -2285,6 +2298,9 @@ exports[`resolved config matches snapshot typescript.ts 1`] = `
     "@typescript-eslint/no-implied-eval": [
       "error",
     ],
+    "@typescript-eslint/no-import-type-side-effects": [
+      "error",
+    ],
     "@typescript-eslint/no-loss-of-precision": [
       "error",
     ],
@@ -4549,6 +4565,19 @@ exports[`resolved config matches snapshot typescript-react.tsx 1`] = `
     "@typescript-eslint/comma-spacing": [
       "off",
     ],
+    "@typescript-eslint/consistent-type-exports": [
+      "error",
+      {
+        "fixMixedExportsWithInlineTypeSpecifier": true,
+      },
+    ],
+    "@typescript-eslint/consistent-type-imports": [
+      "error",
+      {
+        "fixStyle": "inline-type-imports",
+        "prefer": "type-imports",
+      },
+    ],
     "@typescript-eslint/func-call-spacing": [
       "off",
     ],
@@ -4619,6 +4648,9 @@ exports[`resolved config matches snapshot typescript-react.tsx 1`] = `
     "@typescript-eslint/no-implied-eval": [
       "error",
     ],
+    "@typescript-eslint/no-import-type-side-effects": [
+      "error",
+    ],
     "@typescript-eslint/no-loss-of-precision": [
       "error",
     ],