Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

⚡️ ROI improvements #90

Closed
Rikj000 opened this issue Jul 12, 2021 · 5 comments
Closed

⚡️ ROI improvements #90

Rikj000 opened this issue Jul 12, 2021 · 5 comments
Assignees
Labels
Bug - Fixed Issue has been resolved Feature - Enhancement Update or improvement to existing feature Feature - New New feature or pull request
Milestone

Comments

@Rikj000
Copy link
Owner

Rikj000 commented Jul 12, 2021

The MGM community has concluded that ROI in it's current state brings no improvements at all!
It reduced profits & increases drawdown in HyperOpt Results reported on Discord.

In it's current state I recommend leaving it completely off, however I believe we should not give up on it yet as our means to support the sell signals (that aim for selling off with profit) while reducing risk and drawdown!

Thus I propose following improvements done to ROI generation:

☑️ #85: Make it configurable in which trends ROI is allowed to trigger.

☑️ Generate the ROI on a slightly bigger candle size (perhaps configurable, perhaps auto-set) then the weighted buy/sell signals, because now ROI tends to seek to reap profits too fast, resulting in being the main sell reason, but also in decreasing the total profits made when it's enabled. Increasing the candle size for ROI only should lead to it decreasing over a longer timespan, which will hopefully balance things out.

☑️ Introduce a configurable/hyperoptable gap (roi_delay) before ROI would start counting down. This would be another way of giving the sell signals more of a chance to act as the main reason for selling off profitable trades

@Rikj000 Rikj000 added Feature - Enhancement Update or improvement to existing feature Bug - Fix Needed Something isn't working as expected Planned Planned feature, improvement or bugfix (not being worked on yet) Feature - New New feature or pull request labels Jul 12, 2021
@Rikj000 Rikj000 changed the title ROI improvements ⚡️ ROI improvements Sep 5, 2021
@Rikj000
Copy link
Owner Author

Rikj000 commented Oct 5, 2021

Since my last update to this issue I implemented the configurable roi_time_interval_scaling & roi_value_step_scaling settings.
These allow to fine-tune ROI more, and make it less bad.

However it still didn't prove to bring any benefits compared to optimizing MGM without ROI.
I would still keep away from it until above improvements have been implemented.

@Rikj000 Rikj000 added this to the v0.13.0 milestone Oct 6, 2021
@Rikj000 Rikj000 added In Progress This is being worked on and removed Planned Planned feature, improvement or bugfix (not being worked on yet) labels Nov 11, 2021
@Rikj000
Copy link
Owner Author

Rikj000 commented Nov 20, 2021

Slowly but surely ROI is changing into something decent with these new changes! 🔥
I haven't played with much of the config possibilities of the new timeframes section yet so feel free to do so!
Perhaps we can still improve further upon those! 🚀

(All of these tests where done with roi_when_trend already implemented and a timeframe of 30m)

Show/Hide Test Results

HyperOpt - ROI Timeframe = 30m

hyperopt_roi_timeframe_30m_roi_when_trend

HyperOpt - ROI Timeframe = 4h

hyperopt_roi_timeframe_4h_roi_when_trend

BackTest - ROI Timeframe = 30m

backtest_roi_timeframe_30m_roi_when_trend

BackTest - ROI Timeframe = 4h

backtest_roi_timeframe_4h_roi_when_trend

@Rikj000 Rikj000 added Needs Testing This feature, improvement or bugfix still is in need of testing In Progress This is being worked on and removed In Progress This is being worked on labels Nov 21, 2021
@Rikj000 Rikj000 self-assigned this Nov 21, 2021
@Rikj000
Copy link
Owner Author

Rikj000 commented Nov 21, 2021

Happy to announce that the new roi_delay setting (Not yet committed) is another improvement! 🥳

Following test's where done using:

  • HO1 spaces buy sell
  • HO2 spaces buy sell roi+ roi_delay 120
Show/Hide Test Results

HyperOpt - Results

hyperopt_roi_delay

BackTest - Sell Reasons

backtest_roi_delay_sell_reasons

BackTest - Summary

backtest_roi_delay_summary

@Rikj000
Copy link
Owner Author

Rikj000 commented Nov 21, 2021

Test 1

For this test both HO 1 & HO 2 have been done on new random states using spaces = buy sell roi + roi_delay = 300

If we compare these to my previous set of tests then we can notice that it doesn't seem ideal to already HyperOpt ROI on the initial HyperOpt 1 Run.

Show/Hide Test 1 Results

HyperOpt - Results

hyperopt_results_test_1

BackTest - Sell Reasons

backtest_sell_reasons_test_1

BackTest - Summary

backtest_summary_test_1

Test 2

For this test I used the same random states as in my previously posted tests.

  • HO 1: Has been done using spaces = buy sell + unclogger
  • HO 2: Has been done using spaces = buy sell roi + unclogger + roi_delay = 300

These results are better then Test 1, however I think I still prefer the results of my previous post a little better
(Basically same test with roi_delay = 120)

Show/Hide Test 2 Results

HyperOpt - Results

hyperopt_results_test_2

BackTest - Sell Reasons

backtest_sell_reasons_test_2

BackTest - Summary

backtest_summary_test_2

@Rikj000 Rikj000 added Bug - Fixed Issue has been resolved and removed Bug - Fix Needed Something isn't working as expected In Progress This is being worked on Needs Testing This feature, improvement or bugfix still is in need of testing labels Nov 21, 2021
@Rikj000
Copy link
Owner Author

Rikj000 commented Nov 21, 2021

roi_delay implemented in: 7c08e91...5b52cd9

Please test out various possibilities with the new ROI settings!
I so far just tested a handful of configuration possibilities so there's a good chance that we can still improve upon this section! 🚀

@Rikj000 Rikj000 closed this as completed Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug - Fixed Issue has been resolved Feature - Enhancement Update or improvement to existing feature Feature - New New feature or pull request
Projects
None yet
Development

No branches or pull requests

1 participant