Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract_clusters()の引数名, row? pos? #88

Closed
Rindrics opened this issue Jun 26, 2019 · 5 comments
Closed

extract_clusters()の引数名, row? pos? #88

Rindrics opened this issue Jun 26, 2019 · 5 comments

Comments

@Rindrics
Copy link
Owner

(dir = "row", pos = 1) ではなく
(serch_along = "col = 1") とする

@akimanabe
Copy link
Collaborator

良いと思います。 pos よりずっと分かりやすいです。
tidyverse 的な命名法だと
search_row = 1 とか search_col = 1 とか・・・?でも 'along' って言葉はシンプルかつ強い説明力を持っているのでこれで search_along でよさそうですね 😃

@Rindrics
Copy link
Owner Author

Rindrics commented Jul 5, 2019

じゃ

  • search_along_row = 2
  • search_along_col = 3

ですかね?

@akimanabe
Copy link
Collaborator

それでいいと思います 👍

@Rindrics Rindrics changed the title extract_clusters()の引数名を変更 extract_clusters()の引数名, row? pos? Jul 5, 2019
@JK-junkin
Copy link
Collaborator

search_along_、いいですね。search_along_row <=> dir = “horiz” と考えていいですか?

@Rindrics
Copy link
Owner Author

Rindrics commented Jul 8, 2019

search_along_、いいですね。search_along_row <=> dir = “horiz” と考えていいですか?

そうです!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants