Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] In game API using Summoner Name instead of Riot Id #857

Open
HeyPalmer opened this issue Nov 23, 2023 · 15 comments
Open

[BUG] In game API using Summoner Name instead of Riot Id #857

HeyPalmer opened this issue Nov 23, 2023 · 15 comments
Labels
on hold: escalated to team This issue has been escalated to the team that owns the service.

Comments

@HeyPalmer
Copy link

Bug Description
The In game API does not currently support Riot Ids

Problem Description

Using one of the following only yields summoner name without the tagline as needed for the Riot Id

https://127.0.0.1:2999/liveclientdata/allgamedata
or
https://127.0.0.1:2999/liveclientdata/playerlist

Expected Result
/liveclientdata/playerlist should include Riot Id

Actual Result
Only Summoner Name is available from the result.

Repro Steps
Start a game. Go to /liveclientdata/playerlist. Find only a "summonerName" field but not one for "tagLine" or "riotId"

@bonepl
Copy link

bonepl commented Nov 27, 2023

I bump this. activePlayer(Name) webservice has different summonerName than playerList

@tisbells
Copy link
Contributor

Hey there. Developer Relations doesn't own the in game API, but we've raised this and if we hear more information we'll provide an update.

@meesvandongen
Copy link

meesvandongen commented Dec 8, 2023

The response changed to include the #tag. However, allPlayers was not updated yet unfortunately. Would be great if that can still be fixed. Although we can already split by # and tell with relative certainty that two players are equal.

@MWstudio
Copy link

MWstudio commented Dec 12, 2023

https://127.0.0.1:2999/liveclientdata/playerlist
https://127.0.0.1:2999/liveclientdata/eventdata
and others needs tagline.

if same summonerName in a game, can't divide who is it

@xEcEz
Copy link

xEcEz commented Dec 14, 2023

Would be great to see an update about this. Thanks.

@tisbells
Copy link
Contributor

Hey there - We sent a follow-up on this to the team earlier this week, but unfortunately it's unlikely we'll hear any updates until after the new year. If something changes I'll let y'all know

@JoaoDanielRufino
Copy link

Hi @tisbells, any updates on this ?

@tisbells
Copy link
Contributor

Hi @tisbells, any updates on this ?

Unfortunately no updates yet - This work is still being prioritized. I will check in with them and provide more info as I get it

@MWstudio
Copy link

Hi @tisbells , this issue is forgotten from riot?

@tisbells
Copy link
Contributor

tisbells commented May 2, 2024

Hey there - Apologies for the long wait on this. Progress was made this week and you should see some updates for this in PBE today and I believe live with patch 14.10 on May 14. If something changes, I'll provide another update.

@MWstudio
Copy link

MWstudio commented May 10, 2024

@tisbells thank you for update. i checked some apis, but only /liveclientdata/eventdata api return summoner name without tagline

image

@tisbells
Copy link
Contributor

@MWstudio Thanks for letting us know - Are you seeing that in PBE? And are the others returning the Riot ID as expected? Here is a list of the APIs that were supposed to be updated:

"/liveclientdata/activeplayername"
"/liveclientdata/playerlist"
"/liveclientdata/gamestats"
"/liveclientdata/playeritems"
"/liveclientdata/playerscores"
"/liveclientdata/playersummonerspells"
"/liveclientdata/playermainrunes"
"/liveclientdata/activeplayerrunes"
"/liveclientdata/allgamedata"
"/liveclientdata/eventdata" (I will let them know this one is still missing the Riot ID)
"/liveclientdata/activeplayer"
"/liveclientdata/activeplayerabilities"

You should see fields in the response for riotId, riotIdGameName, and riotIdTagLine

@MWstudio
Copy link

@tisbells yes i tested it in PBE Server. other APIs return riotId, riotIdGameName, and riotIdTagLine. but only "/liveclientdata/eventdata" is not updated

@tisbells
Copy link
Contributor

Thanks for confirming, I've let them know!

@AoshiW
Copy link

AoshiW commented May 18, 2024

could you also update the documentation at https://developer.riotgames.com/docs/lol#game-client-api_live-client-data-api? It still uses summonerName for the query parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold: escalated to team This issue has been escalated to the team that owns the service.
Projects
None yet
Development

No branches or pull requests

8 participants