Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRAT Report Style Improvements #948

Closed
philipbaileynar opened this issue May 9, 2024 · 4 comments
Closed

BRAT Report Style Improvements #948

philipbaileynar opened this issue May 9, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request pkg:BRAT BRAT Python Package

Comments

@philipbaileynar
Copy link
Contributor

As a general rule try and implement these fixes at the lowest level possible. In other words, try and use CSS improvements rather than styling individual HTML tags.

  1. Better semantic heading fonts. H1 shoulder be bigger than H2. H2 should be bigger than h3 etc.

  2. Remove the incremental indendation of sections.

Screenshot 2024-05-09 at 12 18 13 PM
  1. Reduce the border around the info boxes to 1px? and drop cell spacing to zero.
Screenshot 2024-05-09 at 12 18 56 PM
  1. Data tables should match info box styling. Set outer border to 1pm. Remove the cell spacing.

  2. Implement "Total" row for all data tables where relevent.

  3. Is there are "one fix all" to avoid pie chart label overlaps?

  4. Are 3D pie charts being used? If so, turn off and make 2D.

Screenshot 2024-05-09 at 12 19 44 PM
  1. What are the redundant horizontal rules HR at the end of the capacity section?
Screenshot 2024-05-09 at 12 22 22 PM
  1. Risk table first column should left aligned.

  2. Risk table has "None" when it should be zero.

  3. Stream discharge plot series should be "riverscapes blue" not burnt orange.

@philipbaileynar philipbaileynar added enhancement New feature or request pkg:BRAT BRAT Python Package labels May 9, 2024
@philipbaileynar
Copy link
Contributor Author

Another request.

Please change the report background to white. Currently it's a subtle cream colour. This doesn't work with the PNG graphics that have a white background and the alternating table rows that also use pure white.

Screenshot 2024-05-09 at 4 23 45 PM

@philipbaileynar
Copy link
Contributor Author

Feedback

  1. Slight gap in cell border? Is this still some cell spacing or padding?
Screenshot 2024-05-13 at 11 03 32 AM
  1. Don't add categories to pie charts that have a value of zero.
  2. In the Hydrology section the "Drainage area threshold" is right aligned but the other items are left aligned. (I think this is some automated behaviour because it is integer and not string or float)
  3. Weird rounding going on. I'm fine if 99.9% rounds to 100%. but the bar in the chart doesn't appear to be at 100%
Screenshot 2024-05-13 at 11 10 06 AM
  1. Missing class. This might require a left join instead of an inner join.
Screenshot 2024-05-13 at 11 11 54 AM
  1. Silly request. Can you remove the colons on the project metadata table after the labels?
Screenshot 2024-05-13 at 11 13 11 AM

@philipbaileynar
Copy link
Contributor Author

Can you use a regex on metadata (or look at the metadata type) and add a hyperlink to URLs?

@r-k-g
Copy link
Contributor

r-k-g commented May 13, 2024

report.zip
Updated report example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg:BRAT BRAT Python Package
Projects
None yet
Development

No branches or pull requests

2 participants