Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speak callable from service or topic #27

Closed
afr2903 opened this issue Apr 11, 2024 · 1 comment
Closed

Speak callable from service or topic #27

afr2903 opened this issue Apr 11, 2024 · 1 comment
Assignees
@afr2903
Labels
enhancement New feature or request

Comments

@afr2903
Copy link
Member

afr2903 commented Apr 11, 2024

Depending on the application, it could be useful to have different ways of calling the Speak feature. For the interact and ask commands, it should be a service. But for debugging feedback from the tasks, it should be asynchronic.
@afr2903 afr2903 added the enhancement New feature or request label Apr 11, 2024
@afr2903 afr2903 self-assigned this Apr 11, 2024
@afr2903 afr2903 mentioned this issue Apr 11, 2024
Closed
@afr2903
Copy link
Member Author

afr2903 commented Apr 17, 2024

This enhancement for having both a topic and a service to call the Speak feature, was implemented inside #36.

Only a subscriber object was added in the node Say.py.

@afr2903 afr2903 closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afr2903 afr2903

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@afr2903