Compatibility for ReflectionFunctionAbstract and ReflectionFunction #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2015
Merged
…), ::inNamespace() methods
…ed, isInternal, isUserDefined
asgrim
force-pushed
the
compat-reflectionfunctionabstract
branch
from
5b0656f
to
a224087
Compare
asgrim
changed the title
| @@ -50,10 +53,12 @@ public function getName() | |||
| public function isMatchingReflector(Reflection $reflector) | |||
| { | |||
| if ($this->name == self::IDENTIFIER_CLASS) { | |||
| return $reflector instanceof ReflectionClass; | |||
| return ($reflector instanceof ReflectionClass); | |||
|
@Ocramius all done |
| if (isset($stmt->stmts) && is_array($stmt->stmts) && count($stmt->stmts)) { | ||
| if ($this->checkStatementsForYield($stmt->stmts)) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Yield is an expression, it does not necessarily occur as a statement. So you should probably do a full traversal to find usages.
There was a problem hiding this comment.
@nikic ahh nice catch there, thanks for pointing this out
| @@ -53,7 +56,9 @@ public function isMatchingReflector(Reflection $reflector) | |||
| return $reflector instanceof ReflectionClass; | |||
| } | |||
|
|
|||
| // @todo add more type checks | |||
Ocramius
added a commit
that referenced
this pull request
Jul 8, 2015
Compatibility for ReflectionFunctionAbstract and ReflectionFunction
|
👍 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #32 being merged first, possibly rebase after etc.This introduces compatibility for #7 items
ReflectionFunctionandReflectionFunctionAbstractwhere possible. Some items are not implement, but marked accordingly in the compatibility list (with corresponding GitHub issues)