Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript type declaration file #264

Open
geopic opened this issue Aug 9, 2020 · 2 comments · May be fixed by #267
Open

TypeScript type declaration file #264

geopic opened this issue Aug 9, 2020 · 2 comments · May be fixed by #267

Comments

@geopic
Copy link

geopic commented Aug 9, 2020

If you want I can write a TypeScript type declaration file for this package so that TS developers can utilise the type-checking feature of the language as they use this package. Let me know if you are interested.
@Rob--W
Copy link
Owner

Rob--W commented Aug 11, 2020

It's welcome if it doesn't cause maintenance issues, for example by including a unit test that checks type that the type definition is still valid (so that I don't cause regressions as I evolve the library).

@geopic
Copy link
Author

geopic commented Aug 11, 2020

Very well, I'll set about doing it now and will include some unit tests as well.

@geopic geopic linked a pull request Aug 11, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add types declaration file with unit tests geopic/cors-anywhere
2 participants
@Rob--W @geopic