Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no proxy url if pointing to self #5

Closed
stevenvachon opened this issue May 30, 2017 · 1 comment
Closed

no proxy url if pointing to self #5

stevenvachon opened this issue May 30, 2017 · 1 comment

Comments

@stevenvachon
Copy link

process.env.HTTP_PROXY = "http://proxy/";
getProxyFromUrl("http://proxy/");
//-> http://proxy/

I think that it should return undefined, since a proxy to the same proxy is redundant.

@Rob--W
Copy link
Owner

Rob--W commented May 30, 2017

I agree that proxying an already-proxied URL is somewhat redundant, but I'm not going to add a special case for the situation because the requests are similar but not strictly equivalent. For example, the proxy might have a different DNS record for the referenced host name (compared to the resolved host name as seen by the client).

@Rob--W Rob--W closed this as completed May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants