Export Luau public symbols to WebAssembly #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only exporting the symbols for the web repl, export all public Luau symbols to the wasm build.
|
Is there a specific reason why this is necessary? |
|
fwiw I think LUA_API should be defined so that it can be externally overridden (ifndef LUA_API -> define LUA_API extern). Which would mean that even if we need to make this change, it'll just affect CMakeLists (assuming we can use a C-friendly way to specify the export that doesn't use Emscripten internal macro) |
|
Going to close this for now, I think this should be achievable with build time only configuration now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only exporting the symbols for the web repl, export all public Luau symbols to the wasm build.